2012-02-23 16:22:13

by Peter De Schrijver

[permalink] [raw]
Subject: [PATCH] ARM: tegra: Avoid compiling cpuidle code when not configured

No need to compile cpuidle.c and sleep.S if cpuidle isn't configured in the
kernel.

Signed-off-by: Peter De Schrijver <[email protected]>
---
arch/arm/mach-tegra/Makefile | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-tegra/Makefile b/arch/arm/mach-tegra/Makefile
index 82994c0..d4c1a6b 100644
--- a/arch/arm/mach-tegra/Makefile
+++ b/arch/arm/mach-tegra/Makefile
@@ -7,8 +7,8 @@ obj-y += clock.o
obj-y += timer.o
obj-y += pinmux.o
obj-y += fuse.o
-obj-y += cpuidle.o
-obj-y += sleep.o
+obj-$(CONFIG_CPU_IDLE) += cpuidle.o
+obj-$(CONFIG_CPU_IDLE) += sleep.o
obj-y += pmc.o
obj-$(CONFIG_ARCH_TEGRA_2x_SOC) += powergate.o
obj-$(CONFIG_ARCH_TEGRA_2x_SOC) += tegra2_clocks.o
--
1.7.7.rc0.72.g4b5ea.dirty


2012-02-23 17:01:08

by Stephen Warren

[permalink] [raw]
Subject: RE: [PATCH] ARM: tegra: Avoid compiling cpuidle code when not configured

Peter De Schrijver wrote at Thursday, February 23, 2012 9:22 AM:
> No need to compile cpuidle.c and sleep.S if cpuidle isn't configured in the
> kernel.
>
> Signed-off-by: Peter De Schrijver <[email protected]>

It doesn't really need it since it's such a small change, but since I
bothered to compile-test it:

Acked-by: Stephen Warren <[email protected]>
Tested-by: Stephen Warren <[email protected]>

--
nvpublic

2012-02-26 22:02:51

by Olof Johansson

[permalink] [raw]
Subject: Re: [PATCH] ARM: tegra: Avoid compiling cpuidle code when not configured

On Thu, Feb 23, 2012 at 06:21:52PM +0200, Peter De Schrijver wrote:
> No need to compile cpuidle.c and sleep.S if cpuidle isn't configured in the
> kernel.

Thanks, applied to for-3.4/soc.

-Olof