2012-02-27 17:44:59

by Artem Bityutskiy

[permalink] [raw]
Subject: [PATCH resend] checkpatch.pl: be silent when -q and --ignore is given

From: Artem Bityutskiy <[email protected]>

This patch fixes checkpatch.pl when both -q and --ignore are given and
prevents it from printing a

NOTE: Ignored message types: blah

messages.

E.g., if I use -q --ignore PREFER_PACKED,PREFER_ALIGNED, i see:

NOTE: Ignored message types: PREFER_ALIGNED PREFER_PACKED

It makes no sense to print this when -q is given.

Signed-off-by: Artem Bityutskiy <[email protected]>
---
scripts/checkpatch.pl | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a3b9782..6fad217 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3394,13 +3394,12 @@ sub process {
}
}

- if (keys %ignore_type) {
+ if ($quiet == 0 && keys %ignore_type) {
print "NOTE: Ignored message types:";
foreach my $ignore (sort keys %ignore_type) {
print " $ignore";
}
- print "\n";
- print "\n" if ($quiet == 0);
+ print "\n\n";
}

if ($clean == 1 && $quiet == 0) {
--
1.7.9


2012-02-29 10:59:43

by Artem Bityutskiy

[permalink] [raw]
Subject: Re: [PATCH resend] checkpatch.pl: be silent when -q and --ignore is given

On Mon, 2012-02-27 at 19:45 +0200, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <[email protected]>
>
> This patch fixes checkpatch.pl when both -q and --ignore are given and
> prevents it from printing a

Andrew, am I right that checkpatch.pl patches go in via your tree?
Should I check linux-next to find out whether you have merged it or not?

--
Best Regards,
Artem Bityutskiy


Attachments:
signature.asc (836.00 B)
This is a digitally signed message part

2012-02-29 11:24:10

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH resend] checkpatch.pl: be silent when -q and --ignore is given

On Wed, 29 Feb 2012 13:02:06 +0200 Artem Bityutskiy <[email protected]> wrote:

> On Mon, 2012-02-27 at 19:45 +0200, Artem Bityutskiy wrote:
> > From: Artem Bityutskiy <[email protected]>
> >
> > This patch fixes checkpatch.pl when both -q and --ignore are given and
> > prevents it from printing a
>
> Andrew, am I right that checkpatch.pl patches go in via your tree?

yup.

> Should I check linux-next to find out whether you have merged it or not?

I applied it, but it seems that for some reason the applied-to-mm email
didn't get sent out for that one.

2012-02-29 11:27:55

by Artem Bityutskiy

[permalink] [raw]
Subject: Re: [PATCH resend] checkpatch.pl: be silent when -q and --ignore is given

On Wed, 2012-02-29 at 03:25 -0800, Andrew Morton wrote:
> I applied it, but it seems that for some reason the applied-to-mm email
> didn't get sent out for that one.

OK, thanks a lot!

--
Best Regards,
Artem Bityutskiy


Attachments:
signature.asc (836.00 B)
This is a digitally signed message part