2012-02-29 15:39:58

by Mark Brown

Subject: [PATCH 3.3] mfd: Correct readability of WM8994 DC servo 4E register

It should be marked as readable but wasn't, breaking DC servo operation.

Signed-off-by: Mark Brown <[email protected]>
---

This needs to go in for 3.3, it's a substantial regression.

drivers/mfd/wm8994-regmap.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mfd/wm8994-regmap.c b/drivers/mfd/wm8994-regmap.c
index 47743fa..ba383f6 100644
--- a/drivers/mfd/wm8994-regmap.c
+++ b/drivers/mfd/wm8994-regmap.c
@@ -806,6 +806,7 @@ static bool wm1811_readable_register(struct device *dev, unsigned int reg)
case WM8994_DC_SERVO_2:
case WM8994_DC_SERVO_READBACK:
case WM8994_DC_SERVO_4:
+ case WM8994_DC_SERVO_4E:
case WM8994_ANALOGUE_HP_1:
case WM8958_MIC_DETECT_1:
case WM8958_MIC_DETECT_2:
--
1.7.9.1

2012-03-01 00:36:39

by Samuel Ortiz

Subject: Re: [PATCH 3.3] mfd: Correct readability of WM8994 DC servo 4E register

Hi Mark,

On Wed, Feb 29, 2012 at 03:37:59PM +0000, Mark Brown wrote:
> It should be marked as readable but wasn't, breaking DC servo operation.
>
> Signed-off-by: Mark Brown <[email protected]>
> ---
>
> This needs to go in for 3.3, it's a substantial regression.
I applied it to my for-linus branch, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/