2012-05-03 14:26:06

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH 08/13] perf target: Split out perf_target handling code

Em Thu, Apr 26, 2012 at 02:15:22PM +0900, Namhyung Kim escreveu:
> For further work on perf_target, it'd be better off splitting
> the code into a separate file.
>
> Signed-off-by: Namhyung Kim <[email protected]>
> ---
> tools/perf/Makefile | 2 ++
> tools/perf/perf.h | 9 +--------
> tools/perf/util/evlist.c | 1 +
> tools/perf/util/evsel.c | 1 +
> tools/perf/util/target.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
> tools/perf/util/target.h | 17 +++++++++++++++++
> tools/perf/util/usage.c | 34 ----------------------------------
> tools/perf/util/util.h | 2 --
> 8 files changed, 67 insertions(+), 44 deletions(-)
> create mode 100644 tools/perf/util/target.c
> create mode 100644 tools/perf/util/target.h

Trying to fix this now...

[acme@sandy linux]$ make -C tools/perf/ O=/home/git/build/perf install
make: Entering directory `/home/git/linux/tools/perf'
CC /home/git/build/perf/builtin-bench.o
CC /home/git/build/perf/bench/sched-messaging.o
CC /home/git/build/perf/bench/sched-pipe.o
CC /home/git/build/perf/scripts/perl/Perf-Trace-Util/Context.o
In file included from
scripts/perl/Perf-Trace-Util/../../../util/target.h:4,
from scripts/perl/Perf-Trace-Util/../../../perf.h:210,
from Context.xs:25:
scripts/perl/Perf-Trace-Util/../../../util/util.h:44:1: error:
"HAS_BOOL" redefined
In file included from /usr/lib64/perl5/CORE/perl.h:2424,
from Context.xs:23:
/usr/lib64/perl5/CORE/handy.h:110:1: error: this is the location of the
previous definition
In file included from
scripts/perl/Perf-Trace-Util/../../../util/target.h:4,
from scripts/perl/Perf-Trace-Util/../../../perf.h:210,
from Context.xs:25:
scripts/perl/Perf-Trace-Util/../../../util/util.h:133: error:
conflicting types for ‘Perl_die_nocontext’
/usr/lib64/perl5/CORE/proto.h:331: note: previous declaration of
‘Perl_die_nocontext’ was here
make: *** [/home/git/build/perf/scripts/perl/Perf-Trace-Util/Context.o]
Error 1
make: Leaving directory `/home/git/linux/tools/perf'
[acme@sandy linux]$

2012-05-03 14:39:58

by Namhyung Kim

Subject: Re: [PATCH 08/13] perf target: Split out perf_target handling code

2012-05-02 (수), 15:30 -0300, Arnaldo Carvalho de Melo:
> Em Thu, Apr 26, 2012 at 02:15:22PM +0900, Namhyung Kim escreveu:
> > For further work on perf_target, it'd be better off splitting
> > the code into a separate file.
> >
> > Signed-off-by: Namhyung Kim <[email protected]>
> > ---
> > tools/perf/Makefile | 2 ++
> > tools/perf/perf.h | 9 +--------
> > tools/perf/util/evlist.c | 1 +
> > tools/perf/util/evsel.c | 1 +
> > tools/perf/util/target.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
> > tools/perf/util/target.h | 17 +++++++++++++++++
> > tools/perf/util/usage.c | 34 ----------------------------------
> > tools/perf/util/util.h | 2 --
> > 8 files changed, 67 insertions(+), 44 deletions(-)
> > create mode 100644 tools/perf/util/target.c
> > create mode 100644 tools/perf/util/target.h
>
> Trying to fix this now...
>

Oops, sorry. I'll investigate it tomorrow.

Thanks,
Namhyung


> [acme@sandy linux]$ make -C tools/perf/ O=/home/git/build/perf install
> make: Entering directory `/home/git/linux/tools/perf'
> CC /home/git/build/perf/builtin-bench.o
> CC /home/git/build/perf/bench/sched-messaging.o
> CC /home/git/build/perf/bench/sched-pipe.o
> CC /home/git/build/perf/scripts/perl/Perf-Trace-Util/Context.o
> In file included from
> scripts/perl/Perf-Trace-Util/../../../util/target.h:4,
> from scripts/perl/Perf-Trace-Util/../../../perf.h:210,
> from Context.xs:25:
> scripts/perl/Perf-Trace-Util/../../../util/util.h:44:1: error:
> "HAS_BOOL" redefined
> In file included from /usr/lib64/perl5/CORE/perl.h:2424,
> from Context.xs:23:
> /usr/lib64/perl5/CORE/handy.h:110:1: error: this is the location of the
> previous definition
> In file included from
> scripts/perl/Perf-Trace-Util/../../../util/target.h:4,
> from scripts/perl/Perf-Trace-Util/../../../perf.h:210,
> from Context.xs:25:
> scripts/perl/Perf-Trace-Util/../../../util/util.h:133: error:
> conflicting types for ‘Perl_die_nocontext’
> /usr/lib64/perl5/CORE/proto.h:331: note: previous declaration of
> ‘Perl_die_nocontext’ was here
> make: *** [/home/git/build/perf/scripts/perl/Perf-Trace-Util/Context.o]
> Error 1
> make: Leaving directory `/home/git/linux/tools/perf'
> [acme@sandy linux]$


--
Regards,
Namhyung Kim

2012-05-03 15:27:41

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH 08/13] perf target: Split out perf_target handling code

Em Thu, May 03, 2012 at 11:39:47PM +0900, Namhyung Kim escreveu:
> 2012-05-02 (수), 15:30 -0300, Arnaldo Carvalho de Melo:
> > Em Thu, Apr 26, 2012 at 02:15:22PM +0900, Namhyung Kim escreveu:
> > > For further work on perf_target, it'd be better off splitting
> > > the code into a separate file.
> > >
> > > Signed-off-by: Namhyung Kim <[email protected]>
> > > ---
> > > tools/perf/Makefile | 2 ++
> > > tools/perf/perf.h | 9 +--------
> > > tools/perf/util/evlist.c | 1 +
> > > tools/perf/util/evsel.c | 1 +
> > > tools/perf/util/target.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
> > > tools/perf/util/target.h | 17 +++++++++++++++++
> > > tools/perf/util/usage.c | 34 ----------------------------------
> > > tools/perf/util/util.h | 2 --
> > > 8 files changed, 67 insertions(+), 44 deletions(-)
> > > create mode 100644 tools/perf/util/target.c
> > > create mode 100644 tools/perf/util/target.h
> >
> > Trying to fix this now...
> >
>
> Oops, sorry. I'll investigate it tomorrow.
>

I fixed it, its on my latest perf/core pull req to Ingo.

- Arnaldo

2012-05-03 15:30:13

by Namhyung Kim

Subject: Re: [PATCH 08/13] perf target: Split out perf_target handling code

2012-05-03 (목), 12:27 -0300, Arnaldo Carvalho de Melo:
> Em Thu, May 03, 2012 at 11:39:47PM +0900, Namhyung Kim escreveu:
> > 2012-05-02 (수), 15:30 -0300, Arnaldo Carvalho de Melo:
> > > Em Thu, Apr 26, 2012 at 02:15:22PM +0900, Namhyung Kim escreveu:
> > > > For further work on perf_target, it'd be better off splitting
> > > > the code into a separate file.
> > > >
> > > > Signed-off-by: Namhyung Kim <[email protected]>
> > > > ---
> > > > tools/perf/Makefile | 2 ++
> > > > tools/perf/perf.h | 9 +--------
> > > > tools/perf/util/evlist.c | 1 +
> > > > tools/perf/util/evsel.c | 1 +
> > > > tools/perf/util/target.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
> > > > tools/perf/util/target.h | 17 +++++++++++++++++
> > > > tools/perf/util/usage.c | 34 ----------------------------------
> > > > tools/perf/util/util.h | 2 --
> > > > 8 files changed, 67 insertions(+), 44 deletions(-)
> > > > create mode 100644 tools/perf/util/target.c
> > > > create mode 100644 tools/perf/util/target.h
> > >
> > > Trying to fix this now...
> > >
> >
> > Oops, sorry. I'll investigate it tomorrow.
> >
>
> I fixed it, its on my latest perf/core pull req to Ingo.
>

Cool :). Thanks a lot, Arnaldo.

Namhyung