2012-05-04 15:31:27

by Rhyland Klein

[permalink] [raw]
Subject: Re: [PATCH] drivers/power/sbs-battery.c: capacity attr = remaining relative capacity

On Tue, 2012-04-24 at 23:59 -0700, Nikolaus Voss wrote:
> Currently, the capacity exported by this driver refers to reg 0x0e,
> which is the absolute state of charge which according to SBS
> refers to the design capacity/ energy of the battery. It can be
> > 100 % and drops below 100 % for a fully charged battery with
> the battery aging.
>
> This is not what the user exspects of a remaining capacity
> indication between 0 and 100 % with 100 % referring to
> a fully charged battery. This is provided by SBS reg 0x0d,
> which is the relative state of charge referring to the
> full charge capacity.
>
> Signed-off-by: Nikolaus Voss <[email protected]>
> ---
> drivers/power/sbs-battery.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

Ack-ed Rhyland Klein <[email protected]>


2012-05-06 03:07:54

by Anton Vorontsov

[permalink] [raw]
Subject: Re: [PATCH] drivers/power/sbs-battery.c: capacity attr = remaining relative capacity

On Fri, May 04, 2012 at 08:24:43AM -0700, Rhyland Klein wrote:
> On Tue, 2012-04-24 at 23:59 -0700, Nikolaus Voss wrote:
> > Currently, the capacity exported by this driver refers to reg 0x0e,
> > which is the absolute state of charge which according to SBS
> > refers to the design capacity/ energy of the battery. It can be
> > > 100 % and drops below 100 % for a fully charged battery with
> > the battery aging.
> >
> > This is not what the user exspects of a remaining capacity
> > indication between 0 and 100 % with 100 % referring to
> > a fully charged battery. This is provided by SBS reg 0x0d,
> > which is the relative state of charge referring to the
> > full charge capacity.
> >
> > Signed-off-by: Nikolaus Voss <[email protected]>
> > ---
> > drivers/power/sbs-battery.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Ack-ed Rhyland Klein <[email protected]>

Applied, thanks!

--
Anton Vorontsov
Email: [email protected]