2012-05-07 07:57:31

by Ying-Chun Liu (PaulLiu)

[permalink] [raw]
Subject: [PATCH] regulator: da9052: fix bug in device tree iteration loop

From: "Ying-Chun Liu (PaulLiu)" <[email protected]>

The driver of da9052 is buggy due to the iteration loop of device tree.
This patch fix the loop condition to make the driver work with device tree.

Signed-off-by: Ying-Chun Liu (PaulLiu) <[email protected]>
---
drivers/regulator/da9052-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/da9052-regulator.c b/drivers/regulator/da9052-regulator.c
index eaa91cc5..f8ad24a 100644
--- a/drivers/regulator/da9052-regulator.c
+++ b/drivers/regulator/da9052-regulator.c
@@ -444,7 +444,7 @@ static int __devinit da9052_regulator_probe(struct platform_device *pdev)
if (!nproot)
return -ENODEV;

- for (np = of_get_next_child(nproot, NULL); !np;
+ for (np = of_get_next_child(nproot, NULL); np;
np = of_get_next_child(nproot, np)) {
if (!of_node_cmp(np->name,
regulator->info->reg_desc.name)) {
--
1.7.10


2012-05-07 11:52:15

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulator: da9052: fix bug in device tree iteration loop

On Mon, May 07, 2012 at 03:57:23PM +0800, Ying-Chun Liu (PaulLiu) wrote:
> From: "Ying-Chun Liu (PaulLiu)" <[email protected]>
>
> The driver of da9052 is buggy due to the iteration loop of device tree.
> This patch fix the loop condition to make the driver work with device tree.

Applied, thanks. I am wondering how this code was ever tested...


Attachments:
(No filename) (350.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments