2012-05-08 10:18:14

by Artem Bityutskiy

[permalink] [raw]
Subject: [PATCH] mips: bcm63xx: fix compilation problems

From: Artem Bityutskiy <[email protected]>

I get the following build error when I am compiling the MTD gpio-nand driver
for bcm63xx:

In file included from arch/mips/include/asm/mach-bcm63xx/gpio.h:4:0,
from arch/mips/include/asm/gpio.h:4,
from include/linux/gpio.h:36,
from drivers/mtd/maps/gpio-addr-flash.c:16:
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h: In function 'bcm63xx_gpio_count':
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:10:2: error: implicit declaration of function 'bcm63xx_get_cpu_id' [-Werror=implicit-function-declaration]
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:11:7: error: 'BCM6358_CPU_ID' undeclared (first use in this function)
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:11:7: note: each undeclared identifier is reported only once for each function it appears in
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:13:7: error: 'BCM6338_CPU_ID' undeclared (first use in this function)
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:15:7: error: 'BCM6345_CPU_ID' undeclared (first use in this function)
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:17:7: error: 'BCM6368_CPU_ID' undeclared (first use in this function)
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:19:7: error: 'BCM6348_CPU_ID' undeclared (first use in this function)

This patch sloves the problem.

Signed-off-by: Artem Bityutskiy <[email protected]>
---
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h
index 3d5de96..b4b9103 100644
--- a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h
+++ b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h
@@ -1,6 +1,7 @@
#ifndef BCM63XX_GPIO_H
#define BCM63XX_GPIO_H

+#include "bcm63xx_cpu.h"
#include <linux/init.h>

int __init bcm63xx_gpio_init(void);
--
1.7.9.1


2012-05-08 12:49:04

by Jonas Gorski

[permalink] [raw]
Subject: Re: [PATCH] mips: bcm63xx: fix compilation problems

Hi Artem,

On 8 May 2012 12:19, Artem Bityutskiy <[email protected]> wrote:
> From: Artem Bityutskiy <[email protected]>
>
> I get the following build error when I am compiling the MTD gpio-nand driver
> for bcm63xx:
>
> In file included from arch/mips/include/asm/mach-bcm63xx/gpio.h:4:0,
>                 from arch/mips/include/asm/gpio.h:4,
>                 from include/linux/gpio.h:36,
>                 from drivers/mtd/maps/gpio-addr-flash.c:16:
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h: In function 'bcm63xx_gpio_count':
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:10:2: error: implicit declaration of function 'bcm63xx_get_cpu_id' [-Werror=implicit-function-declaration]
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:11:7: error: 'BCM6358_CPU_ID' undeclared (first use in this function)
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:11:7: note: each undeclared identifier is reported only once for each function it appears in
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:13:7: error: 'BCM6338_CPU_ID' undeclared (first use in this function)
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:15:7: error: 'BCM6345_CPU_ID' undeclared (first use in this function)
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:17:7: error: 'BCM6368_CPU_ID' undeclared (first use in this function)
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:19:7: error: 'BCM6348_CPU_ID' undeclared (first use in this function)
>
> (snip)

I already submitted almost the same patch ~3 months ago:
http://patchwork.linux-mips.org/patch/3351/

> This patch sloves the problem.

"sloves"? ;p


Jonas