2012-05-10 14:53:25

by Emil Goode

Subject: [PATCH] drm/exynos: Include missing linux/types.h in header

Include the linux/types.h file where used types are declared.

Sparse gives the following warning:
/usr/include/drm/exynos_drm.h:92:
found __[us]{8,16,32,64} type without
#include <linux/types.h>

Signed-off-by: Emil Goode <[email protected]>
---
include/drm/exynos_drm.h | 2 ++
1 file changed, 2 insertions(+)

diff --git a/include/drm/exynos_drm.h b/include/drm/exynos_drm.h
index e478de4..7eb7ae7 100644
--- a/include/drm/exynos_drm.h
+++ b/include/drm/exynos_drm.h
@@ -29,6 +29,8 @@
#ifndef _EXYNOS_DRM_H_
#define _EXYNOS_DRM_H_

+#include <linux/types.h>
+
/**
* User-desired buffer creation information structure.
*
--
1.7.10

2012-05-14 02:24:31

by Inki Dae

Subject: Re: [PATCH] drm/exynos: Include missing linux/types.h in header

2012/5/10 Emil Goode <[email protected]>:
> Include the linux/types.h file where used types are declared.
>
> Sparse gives the following warning:
> /usr/include/drm/exynos_drm.h:92:
> ? ? ? ?found __[us]{8,16,32,64} type without
> ? ? ? ?#include <linux/types.h>
>
> Signed-off-by: Emil Goode <[email protected]>
> ---
> ?include/drm/exynos_drm.h | ? ?2 ++
> ?1 file changed, 2 insertions(+)
>
> diff --git a/include/drm/exynos_drm.h b/include/drm/exynos_drm.h
> index e478de4..7eb7ae7 100644
> --- a/include/drm/exynos_drm.h
> +++ b/include/drm/exynos_drm.h
> @@ -29,6 +29,8 @@
> ?#ifndef _EXYNOS_DRM_H_
> ?#define _EXYNOS_DRM_H_
>
> +#include <linux/types.h>
> +

applied.

Thanks,
Inki Dae

> ?/**
> ?* User-desired buffer creation information structure.
> ?*
> --
> 1.7.10
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

2012-06-04 15:52:51

by Inki Dae

Subject: Re: [PATCH] drm/exynos: Include missing linux/types.h in header

Hi Emil,

we included "drm.h" with g2d driver patch instead of "<linux/types.h>
so your patch will be removed from exynos-drm-fixes. sorry for
confusing.

for this, you can refer to below link.
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blobdiff;f=include/drm/exynos_drm.h;h=b6d7ce92eadd67a67db12b19bb0d39208b870511;hp=44f79cf468d4b7baff2e5f728667475ab96f7f1e;hb=d7f1642c90ab5eb2d7c48af0581c993094f97e1a;hpb=8dcb96b628a0749184bbcc5e6c94463f89405c58

Thanks,
Inki Dae

2012/5/14 InKi Dae <[email protected]>:
> 2012/5/10 Emil Goode <[email protected]>:
>> Include the linux/types.h file where used types are declared.
>>
>> Sparse gives the following warning:
>> /usr/include/drm/exynos_drm.h:92:
>> ? ? ? ?found __[us]{8,16,32,64} type without
>> ? ? ? ?#include <linux/types.h>
>>
>> Signed-off-by: Emil Goode <[email protected]>
>> ---
>> ?include/drm/exynos_drm.h | ? ?2 ++
>> ?1 file changed, 2 insertions(+)
>>
>> diff --git a/include/drm/exynos_drm.h b/include/drm/exynos_drm.h
>> index e478de4..7eb7ae7 100644
>> --- a/include/drm/exynos_drm.h
>> +++ b/include/drm/exynos_drm.h
>> @@ -29,6 +29,8 @@
>> ?#ifndef _EXYNOS_DRM_H_
>> ?#define _EXYNOS_DRM_H_
>>
>> +#include <linux/types.h>
>> +
>
> applied.
>
> Thanks,
> Inki Dae
>
>> ?/**
>> ?* User-desired buffer creation information structure.
>> ?*
>> --
>> 1.7.10
>>
>> _______________________________________________
>> dri-devel mailing list
>> [email protected]
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel