2012-05-11 05:55:36

by joseph daniel

[permalink] [raw]

Subject: [PATCH] usb/dwc3: Fix the dwc3 dependency

---

The warning shown up when ran with randconfig,

warning: (USB_DWC3) selects USB_XHCI_PLATFORM which has unmet direct dependencies (USB_SUPPORT && USB_XHCI_HCD)

Signed-off-by: joseph daniel <[email protected]>
---
drivers/usb/dwc3/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
index d8f741f..68271fa 100644
--- a/drivers/usb/dwc3/Kconfig
+++ b/drivers/usb/dwc3/Kconfig
@@ -1,6 +1,6 @@
config USB_DWC3
tristate "DesignWare USB3 DRD Core Support"
- depends on (USB && USB_GADGET)
+ depends on (USB && USB_SUPPORT && USB_XCHI_HCD && USB_GADGET)
select USB_OTG_UTILS
select USB_GADGET_DUALSPEED
select USB_GADGET_SUPERSPEED
--
1.7.9.5

2012-05-11 07:59:01

by Felipe Balbi

[permalink] [raw]

Subject: Re: [PATCH] usb/dwc3: Fix the dwc3 dependency

---

On Fri, May 11, 2012 at 11:25:24AM +0530, joseph daniel wrote:
> The warning shown up when ran with randconfig,
>
> warning: (USB_DWC3) selects USB_XHCI_PLATFORM which has unmet direct dependencies (USB_SUPPORT && USB_XHCI_HCD)
>
> Signed-off-by: joseph daniel <[email protected]>
> ---
> drivers/usb/dwc3/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index d8f741f..68271fa 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -1,6 +1,6 @@
> config USB_DWC3
> tristate "DesignWare USB3 DRD Core Support"
> - depends on (USB && USB_GADGET)
> + depends on (USB && USB_SUPPORT && USB_XCHI_HCD && USB_GADGET)
^^^^
typo

I would prefer the select to change:

select XHCI_PLATFORM if (USB_SUPPORT && USB_XHCI_HCD)

or something similar.

> select USB_OTG_UTILS
> select USB_GADGET_DUALSPEED
> select USB_GADGET_SUPERSPEED

--
balbi

---

Attachments:

(No filename) (991.00 B)
signature.asc (836.00 B)
Digital signature Download all attachments

2012-05-11 10:09:16

by joseph daniel

[permalink] [raw]

Subject: Re: [PATCH] usb/dwc3: Fix the dwc3 dependency

---

Hi Felipe,

On Fri, May 11, 2012 at 1:27 PM, Felipe Balbi <[email protected]> wrote:
> On Fri, May 11, 2012 at 11:25:24AM +0530, joseph daniel wrote:
>> The warning shown up when ran with randconfig,
>>
>> warning: (USB_DWC3) selects USB_XHCI_PLATFORM which has unmet direct dependencies (USB_SUPPORT && USB_XHCI_HCD)
>>
>> Signed-off-by: joseph daniel <[email protected]>
>> ---
>> ?drivers/usb/dwc3/Kconfig | ? ?2 +-
>> ?1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
>> index d8f741f..68271fa 100644
>> --- a/drivers/usb/dwc3/Kconfig
>> +++ b/drivers/usb/dwc3/Kconfig
>> @@ -1,6 +1,6 @@
>> ?config USB_DWC3
>> ? ? ? tristate "DesignWare USB3 DRD Core Support"
>> - ? ? depends on (USB && USB_GADGET)
>> + ? ? depends on (USB && USB_SUPPORT && USB_XCHI_HCD && USB_GADGET)
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?^^^^
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?typo
>
> I would prefer the select to change:
>
> select XHCI_PLATFORM if (USB_SUPPORT && USB_XHCI_HCD)
>
will do this and send out a patch shotly.
> or something similar.
>
>> ? ? ? select USB_OTG_UTILS
>> ? ? ? select USB_GADGET_DUALSPEED
>> ? ? ? select USB_GADGET_SUPERSPEED
>
> --
> balbi

Thanks

2012-05-11 11:21:31

by Sergei Shtylyov

[permalink] [raw]

Subject: Re: [PATCH] usb/dwc3: Fix the dwc3 dependency

---

Hello.

On 11-05-2012 9:55, joseph daniel wrote:

> The warning shown up when ran with randconfig,

> warning: (USB_DWC3) selects USB_XHCI_PLATFORM which has unmet direct dependencies (USB_SUPPORT&& USB_XHCI_HCD)

> Signed-off-by: joseph daniel<[email protected]>
> ---
> drivers/usb/dwc3/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index d8f741f..68271fa 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -1,6 +1,6 @@
> config USB_DWC3
> tristate "DesignWare USB3 DRD Core Support"
> - depends on (USB&& USB_GADGET)
> + depends on (USB&& USB_SUPPORT&& USB_XCHI_HCD&& USB_GADGET)

Parens not needed -- could as well get rid of them.

WBR, Sergei