2012-05-14 09:13:21

by Mark Brown

Subject: [PATCH 1/2] mfd: wm8400: Don't support non-modular build

It's relying on non-exported symbols.

Reported-by: Stephen Rothwell <[email protected]>
Signed-off-by: Mark Brown <[email protected]>
---
drivers/mfd/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 8a767a6..0ff6d54 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -468,7 +468,7 @@ config MFD_S5M_CORE
of the device

config MFD_WM8400
- tristate "Support Wolfson Microelectronics WM8400"
+ bool "Support Wolfson Microelectronics WM8400"
select MFD_CORE
depends on I2C
select REGMAP_I2C
--
1.7.10

2012-05-14 09:13:22

by Mark Brown

Subject: [PATCH 2/2] mfd: wm8400: Export wm8400_block_read()

Used by the regulator driver.

Reported-by: Stephen Rothwell <[email protected]>
Signed-off-by: Mark Brown <[email protected]>
---
drivers/mfd/wm8400-core.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/wm8400-core.c b/drivers/mfd/wm8400-core.c
index 9083b77..4b7d378 100644
--- a/drivers/mfd/wm8400-core.c
+++ b/drivers/mfd/wm8400-core.c
@@ -60,6 +60,7 @@ int wm8400_block_read(struct wm8400 *wm8400, u8 reg, int count, u16 *data)
{
return regmap_bulk_read(wm8400->regmap, reg, data, count);
}
+EXPORT_SYMBOL_GPL(wm8400_block_read);

static int wm8400_register_codec(struct wm8400 *wm8400)
{
--
1.7.10

2012-05-14 20:11:35

by Samuel Ortiz

Subject: Re: [PATCH 1/2] mfd: wm8400: Don't support non-modular build

Hi Mark,

On Mon, May 14, 2012 at 10:13:15AM +0100, Mark Brown wrote:
> It's relying on non-exported symbols.
>
> Reported-by: Stephen Rothwell <[email protected]>
> Signed-off-by: Mark Brown <[email protected]>
Both patches applied, thanks a lot.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/