2012-05-14 16:15:46

by Reinhard Tartler

[permalink] [raw]
Subject: [PATCH] usb: musb: cppi: add missing include to fix compilation

This fixes compilation as module.

Signed-off-by: Reinhard Tartler <[email protected]>
---
drivers/usb/musb/cppi_dma.c | 1 +
1 file changed, 1 insertion(+)

This patch was found by tools developed in the VAMOS project:
http://www4.cs.fau.de/Research/VAMOS/

diff --git a/drivers/usb/musb/cppi_dma.c b/drivers/usb/musb/cppi_dma.c
index 318fb4e..b25451f 100644
--- a/drivers/usb/musb/cppi_dma.c
+++ b/drivers/usb/musb/cppi_dma.c
@@ -6,6 +6,7 @@
* The TUSB6020, using VLYNQ, has CPPI that looks much like DaVinci.
*/

+#include <linux/module.h>
#include <linux/platform_device.h>
#include <linux/slab.h>
#include <linux/usb.h>
--
1.7.9.5


2012-05-14 16:31:59

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] usb: musb: cppi: add missing include to fix compilation

On Mon, May 14, 2012 at 06:05:20PM +0200, Reinhard Tartler wrote:
> This fixes compilation as module.
>
> Signed-off-by: Reinhard Tartler <[email protected]>
> ---
> drivers/usb/musb/cppi_dma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> This patch was found by tools developed in the VAMOS project:
> http://www4.cs.fau.de/Research/VAMOS/

Does that mean that no one actually can hit this in "real life"? Or is
there a valid .config that this solves a problem for? If so, is it also
needed for the 3.4/3.3-stable tree and older ones?

thanks,

greg k-h

2012-05-14 17:27:20

by Sergei Shtylyov

[permalink] [raw]
Subject: Re: [PATCH] usb: musb: cppi: add missing include to fix compilation

Hello.

On 05/14/2012 08:53 PM, Reinhard Tartler wrote:

>> On Mon, May 14, 2012 at 06:05:20PM +0200, Reinhard Tartler wrote:
>>> This fixes compilation as module.

>>> Signed-off-by: Reinhard Tartler<[email protected]>
>>> ---
>>> drivers/usb/musb/cppi_dma.c | 1 +
>>> 1 file changed, 1 insertion(+)

>>> This patch was found by tools developed in the VAMOS project:
>>> http://www4.cs.fau.de/Research/VAMOS/

>> Does that mean that no one actually can hit this in "real life"? Or is
>> there a valid .config that this solves a problem for? If so, is it also
>> needed for the 3.4/3.3-stable tree and older ones?

> My tool has generated the attached configuration that exposes this
> compilation failure. I have used kernel v3.2 with Ubuntu's arm
> cross-compiler for the analysis and verification.

Strange, your .config indicated that DMA driver and MUSB driver into which
it is linked are build monolithic. You also should use 3.3 series kernel.

> Cheers,
> Reinhard

WBR, Sergei

2012-05-14 18:36:04

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] usb: musb: cppi: add missing include to fix compilation

On Mon, May 14, 2012 at 06:53:31PM +0200, Reinhard Tartler wrote:
> On Mo, Mai 14, 2012 at 18:31:54 (CEST), Greg KH wrote:
>
> > On Mon, May 14, 2012 at 06:05:20PM +0200, Reinhard Tartler wrote:
> >> This fixes compilation as module.
> >>
> >> Signed-off-by: Reinhard Tartler <[email protected]>
> >> ---
> >> drivers/usb/musb/cppi_dma.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> This patch was found by tools developed in the VAMOS project:
> >> http://www4.cs.fau.de/Research/VAMOS/
> >
> > Does that mean that no one actually can hit this in "real life"? Or is
> > there a valid .config that this solves a problem for? If so, is it also
> > needed for the 3.4/3.3-stable tree and older ones?
>
> My tool has generated the attached configuration that exposes this
> compilation failure. I have used kernel v3.2 with Ubuntu's arm
> cross-compiler for the analysis and verification.

Does this show up on the 3.4-rc kernels? 3.3? I can't do anything
about going back in time and fixing 3.2 right now, sorry.

greg k-h