2012-05-25 12:37:24

by Wanpeng Li

Subject: remove repeat implementation of page_referenced

From: Wanpeng Li <[email protected]>

page_referenced function just called from mm/vmscan.c to handle paging
out.It is realized in mm/rmap.c and has an interface exported in rmap.h.

Signed-off-by: Wanpeng Li <[email protected]>
---
include/linux/rmap.h | 8 --------
1 file changed, 8 deletions(-)

diff --git a/include/linux/rmap.h b/include/linux/rmap.h
index fd07c45..ee0c005 100644
--- a/include/linux/rmap.h
+++ b/include/linux/rmap.h
@@ -234,14 +234,6 @@ int rmap_walk(struct page *page, int (*rmap_one)(struct page *,
#define anon_vma_prepare(vma) (0)
#define anon_vma_link(vma) do {} while (0)

-static inline int page_referenced(struct page *page, int is_locked,
- struct mem_cgroup *memcg,
- unsigned long *vm_flags)
-{
- *vm_flags = 0;
- return 0;
-}
-
#define try_to_unmap(page, refs) SWAP_FAIL

static inline int page_mkclean(struct page *page)
--
1.7.9.5

2012-05-25 12:47:40

by Peter Zijlstra

Subject: Re: remove repeat implementation of page_referenced

On Fri, 2012-05-25 at 20:37 +0800, Wanpeng Li wrote:
> From: Wanpeng Li <[email protected]>
>
> page_referenced function just called from mm/vmscan.c to handle paging
> out.It is realized in mm/rmap.c and has an interface exported in rmap.h.

I think you'll find you've broken CONFIG_MMU=n builds with this.