2012-05-26 03:42:01

by Namhyung Kim

Subject: [PATCH] tools libtraceevent: Silence compiler warning on 32bit build

The gcc complains about casting a pointer to unsigned long long directly:

SUBDIR ../lib/traceevent/
CC FPIC event-parse.o
CC FPIC trace-seq.o
CC FPIC parse-filter.o
/home/namhyung/project/linux/tools/lib/traceevent/parse-filter.c: In function ‘get_value’:
/home/namhyung/project/linux/tools/lib/traceevent/parse-filter.c:1588: warning: cast from pointer to integer of different size
CC FPIC parse-utils.o
BUILD STATIC LIB libtraceevent.a

Signed-off-by: Namhyung Kim <[email protected]>
---
tools/lib/traceevent/parse-filter.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c
index 2d40c5e..aa30b43 100644
--- a/tools/lib/traceevent/parse-filter.c
+++ b/tools/lib/traceevent/parse-filter.c
@@ -1585,7 +1585,7 @@ get_value(struct event_format *event,
const char *name;

name = get_comm(event, record);
- return (unsigned long long)name;
+ return (unsigned long)name;
}

pevent_read_number_field(field, record->data, &val);
--
1.7.2.2

2012-05-26 17:16:58

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] tools libtraceevent: Silence compiler warning on 32bit build

Em Sat, May 26, 2012 at 12:41:31PM +0900, Namhyung Kim escreveu:
> The gcc complains about casting a pointer to unsigned long long directly:
>
> SUBDIR ../lib/traceevent/
> CC FPIC event-parse.o
> CC FPIC trace-seq.o
> CC FPIC parse-filter.o
> /home/namhyung/project/linux/tools/lib/traceevent/parse-filter.c: In function ‘get_value’:
> /home/namhyung/project/linux/tools/lib/traceevent/parse-filter.c:1588: warning: cast from pointer to integer of different size
> CC FPIC parse-utils.o
> BUILD STATIC LIB libtraceevent.a
>
> Signed-off-by: Namhyung Kim <[email protected]>
> ---
> tools/lib/traceevent/parse-filter.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c
> index 2d40c5e..aa30b43 100644
> --- a/tools/lib/traceevent/parse-filter.c
> +++ b/tools/lib/traceevent/parse-filter.c
> @@ -1585,7 +1585,7 @@ get_value(struct event_format *event,
> const char *name;
>
> name = get_comm(event, record);
> - return (unsigned long long)name;
> + return (unsigned long)name;

Thanks, applied to my perf/urgent branch,

- Arnaldo

2012-05-30 07:48:34

by Namhyung Kim

Subject: [tip:perf/urgent] tools lib traceevent: Silence compiler warning on 32bit build

Commit-ID: 42c59cdab42b8909454e0d434e3977cd3b636fbd
Gitweb: http://git.kernel.org/tip/42c59cdab42b8909454e0d434e3977cd3b636fbd
Author: Namhyung Kim <[email protected]>
AuthorDate: Sat, 26 May 2012 12:41:31 +0900
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Sat, 26 May 2012 14:14:58 -0300

tools lib traceevent: Silence compiler warning on 32bit build

The gcc complains about casting a pointer to unsigned long long directly:

SUBDIR ../lib/traceevent/
CC FPIC event-parse.o
CC FPIC trace-seq.o
CC FPIC parse-filter.o
/home/namhyung/project/linux/tools/lib/traceevent/parse-filter.c: In function ‘get_value’:
/home/namhyung/project/linux/tools/lib/traceevent/parse-filter.c:1588: warning: cast from pointer to integer of different size
CC FPIC parse-utils.o
BUILD STATIC LIB libtraceevent.a

Signed-off-by: Namhyung Kim <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Steven Rostedt <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/lib/traceevent/parse-filter.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c
index e08d21f..dfcfe2c 100644
--- a/tools/lib/traceevent/parse-filter.c
+++ b/tools/lib/traceevent/parse-filter.c
@@ -1584,7 +1584,7 @@ get_value(struct event_format *event,
const char *name;

name = get_comm(event, record);
- return (unsigned long long)name;
+ return (unsigned long)name;
}

pevent_read_number_field(field, record->data, &val);