2012-05-28 09:04:14

by Eric Miao

Subject: [PATCH] fbdev: make FIRMWARE_EDID depends on X86

The only place where CONFIG_FIRMWARE_EDID is used is in fbmon.c,
and only when CONFIG_X86 is defined, this implied dependency will
be better specified in Kconfig. Otherwise, CONFIG_FIRMWARE_EDID
can be turned on pointlessly for other architectures, and causing
a bit confusion when doing configs across different architectures.

Signed-off-by: Eric Miao <[email protected]>
---
drivers/video/Kconfig | 2 +-
drivers/video/fbmon.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index a290be5..61af035 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -69,7 +69,7 @@ menuconfig FB

config FIRMWARE_EDID
bool "Enable firmware EDID"
- depends on FB
+ depends on FB && X86
default n
---help---
This enables access to the EDID transferred from the firmware.
diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c
index cef6557..e8ada4d 100644
--- a/drivers/video/fbmon.c
+++ b/drivers/video/fbmon.c
@@ -1458,7 +1458,7 @@ int fb_validate_mode(const struct fb_var_screeninfo *var, struct fb_info *info)
-EINVAL : 0;
}

-#if defined(CONFIG_FIRMWARE_EDID) && defined(CONFIG_X86)
+#ifdef CONFIG_FIRMWARE_EDID

/*
* We need to ensure that the EDID block is only returned for
--
1.7.9.5

2012-05-28 18:34:38

by Eric Miao

Subject: Re: [PATCH] fbdev: make FIRMWARE_EDID depends on X86

On Mon, May 28, 2012 at 5:04 PM, Eric Miao <[email protected]> wrote:
> The only place where CONFIG_FIRMWARE_EDID is used is in fbmon.c,
> and only when CONFIG_X86 is defined, this implied dependency will
> be better specified in Kconfig.  Otherwise, CONFIG_FIRMWARE_EDID
> can be turned on pointlessly for other architectures, and causing
> a bit confusion when doing configs across different architectures.

Sorry, should be 'when doing config comparisons across different architectures'.