2012-06-03 14:46:25

by Axel Lin

[permalink] [raw]
Subject: [PATCH] regulator: max77686: Use regulator_map_voltage_linear for simple linear mappings

Both max77686_ops and max77686_buck_dvs_ops use simple linear voltage maps.
Thus use regulator_map_voltage_linear is more efficient than using the defult
regulator_map_voltage_iterate.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/max77686.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/regulator/max77686.c b/drivers/regulator/max77686.c
index 70046f8..4e9f4f3 100644
--- a/drivers/regulator/max77686.c
+++ b/drivers/regulator/max77686.c
@@ -90,6 +90,7 @@ static int max77686_set_voltage_time_sel(struct regulator_dev *rdev,

static struct regulator_ops max77686_ops = {
.list_voltage = regulator_list_voltage_linear,
+ .map_voltage = regulator_map_voltage_linear,
.is_enabled = regulator_is_enabled_regmap,
.enable = regulator_enable_regmap,
.disable = regulator_disable_regmap,
@@ -100,6 +101,7 @@ static struct regulator_ops max77686_ops = {

static struct regulator_ops max77686_buck_dvs_ops = {
.list_voltage = regulator_list_voltage_linear,
+ .map_voltage = regulator_map_voltage_linear,
.is_enabled = regulator_is_enabled_regmap,
.enable = regulator_enable_regmap,
.disable = regulator_disable_regmap,
--
1.7.9.5



2012-06-03 19:10:59

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulator: max77686: Use regulator_map_voltage_linear for simple linear mappings

On Sun, Jun 03, 2012 at 10:46:14PM +0800, Axel Lin wrote:
> Both max77686_ops and max77686_buck_dvs_ops use simple linear voltage maps.
> Thus use regulator_map_voltage_linear is more efficient than using the defult
> regulator_map_voltage_iterate.

I've applied this and your other patch but really what should happen
here is that the default should get smarter and use map_voltage_linear()
if list_voltage_linear() is in use and nothing is set.


Attachments:
(No filename) (447.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments