2012-06-04 11:50:48

by Sachin Kamat

Subject: [PATCH 1/1] DMA: PL330: Add missing static storage class specifier

Fixes the following sparse warning:
drivers/dma/pl330.c:2542:5: warning: symbol 'add_desc' was not declared. Should it be static?

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/dma/pl330.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index cbcc28e..63b6ad5 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -2539,7 +2539,7 @@ static inline void _init_desc(struct dma_pl330_desc *desc)
}

/* Returns the number of descriptors added to the DMAC pool */
-int add_desc(struct dma_pl330_dmac *pdmac, gfp_t flg, int count)
+static int add_desc(struct dma_pl330_dmac *pdmac, gfp_t flg, int count)
{
struct dma_pl330_desc *desc;
unsigned long flags;
--
1.7.4.1

2012-06-07 08:31:25

by Vinod Koul

Subject: Re: [PATCH 1/1] DMA: PL330: Add missing static storage class specifier

On Mon, 2012-06-04 at 17:09 +0530, Sachin Kamat wrote:
> Fixes the following sparse warning:
> drivers/dma/pl330.c:2542:5: warning: symbol 'add_desc' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <[email protected]>
> ---
> drivers/dma/pl330.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index cbcc28e..63b6ad5 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -2539,7 +2539,7 @@ static inline void _init_desc(struct dma_pl330_desc *desc)
> }
>
> /* Returns the number of descriptors added to the DMAC pool */
> -int add_desc(struct dma_pl330_dmac *pdmac, gfp_t flg, int count)
> +static int add_desc(struct dma_pl330_dmac *pdmac, gfp_t flg, int count)
> {
> struct dma_pl330_desc *desc;
> unsigned long flags;

Applied, thanks
--
~Vinod