2012-06-08 23:41:52

by Axel Lin

Subject: [PATCH] leds: Make LEDS_ASIC3 and LEDS_RENESAS_TPU depend on LEDS_CLASS=y

Otherwise, I got below build error when CONFIG_LEDS_CLASS=m.

LD init/built-in.o
drivers/built-in.o: In function `asic3_led_probe':
clkdev.c:(.devinit.text+0x4680): undefined reference to `led_classdev_register'
drivers/built-in.o: In function `r_tpu_probe':
clkdev.c:(.devinit.text+0x4838): undefined reference to `led_classdev_register'
drivers/built-in.o: In function `asic3_led_remove':
clkdev.c:(.devexit.text+0x564): undefined reference to `led_classdev_unregister'
drivers/built-in.o: In function `r_tpu_remove':
clkdev.c:(.devexit.text+0x5a0): undefined reference to `led_classdev_unregister'
make: *** [vmlinux] Error 1

Signed-off-by: Axel Lin <[email protected]>
---
drivers/leds/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 04cb8c8..12b2b55 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -379,7 +379,7 @@ config LEDS_NETXBIG

config LEDS_ASIC3
bool "LED support for the HTC ASIC3"
- depends on LEDS_CLASS
+ depends on LEDS_CLASS=y
depends on MFD_ASIC3
default y
help
@@ -390,7 +390,7 @@ config LEDS_ASIC3

config LEDS_RENESAS_TPU
bool "LED support for Renesas TPU"
- depends on LEDS_CLASS && HAVE_CLK && GENERIC_GPIO
+ depends on LEDS_CLASS=y && HAVE_CLK && GENERIC_GPIO
help
This option enables build of the LED TPU platform driver,
suitable to drive any TPU channel on newer Renesas SoCs.
--
1.7.9.5

2012-06-11 14:38:04

by Bryan Wu

Subject: Re: [PATCH] leds: Make LEDS_ASIC3 and LEDS_RENESAS_TPU depend on LEDS_CLASS=y

On Sat, Jun 9, 2012 at 7:41 AM, Axel Lin <[email protected]> wrote:
> Otherwise, I got below build error when CONFIG_LEDS_CLASS=m.
>
> ?LD ? ? ?init/built-in.o
> drivers/built-in.o: In function `asic3_led_probe':
> clkdev.c:(.devinit.text+0x4680): undefined reference to `led_classdev_register'
> drivers/built-in.o: In function `r_tpu_probe':
> clkdev.c:(.devinit.text+0x4838): undefined reference to `led_classdev_register'
> drivers/built-in.o: In function `asic3_led_remove':
> clkdev.c:(.devexit.text+0x564): undefined reference to `led_classdev_unregister'
> drivers/built-in.o: In function `r_tpu_remove':
> clkdev.c:(.devexit.text+0x5a0): undefined reference to `led_classdev_unregister'
> make: *** [vmlinux] Error 1
>
> Signed-off-by: Axel Lin <[email protected]>

Good, applied to my fixes-for-3.5 branch.

Thanks
-Bryan

> ---
> ?drivers/leds/Kconfig | ? ?4 ++--
> ?1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index 04cb8c8..12b2b55 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -379,7 +379,7 @@ config LEDS_NETXBIG
>
> ?config LEDS_ASIC3
> ? ? ? ?bool "LED support for the HTC ASIC3"
> - ? ? ? depends on LEDS_CLASS
> + ? ? ? depends on LEDS_CLASS=y
> ? ? ? ?depends on MFD_ASIC3
> ? ? ? ?default y
> ? ? ? ?help
> @@ -390,7 +390,7 @@ config LEDS_ASIC3
>
> ?config LEDS_RENESAS_TPU
> ? ? ? ?bool "LED support for Renesas TPU"
> - ? ? ? depends on LEDS_CLASS && HAVE_CLK && GENERIC_GPIO
> + ? ? ? depends on LEDS_CLASS=y && HAVE_CLK && GENERIC_GPIO
> ? ? ? ?help
> ? ? ? ? ?This option enables build of the LED TPU platform driver,
> ? ? ? ? ?suitable to drive any TPU channel on newer Renesas SoCs.
> --
> 1.7.9.5
>
>
>



--
Bryan Wu <[email protected]>
Kernel Developer ? ?+86.186-168-78255 Mobile
Canonical Ltd. ? ? ?http://www.canonical.com
Ubuntu - Linux for human beings | http://www.ubuntu.com