2012-06-09 11:45:44

by Wanpeng Li

Subject: [PATCH] mm/page-writeback.c: fix comments error in page-writeback.c

From: Wanpeng Li <[email protected]>

Signed-off-by: Wanpeng Li <[email protected]>
---
mm/page-writeback.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 93d8d2f..c833bf0 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -930,7 +930,7 @@ static void bdi_update_dirty_ratelimit(struct backing_dev_info *bdi,
*/

/*
- * dirty_ratelimit will follow balanced_dirty_ratelimit iff
+ * dirty_ratelimit will follow balanced_dirty_ratelimit if
* task_ratelimit is on the same side of dirty_ratelimit, too.
* For example, when
* - dirty_ratelimit > balanced_dirty_ratelimit
@@ -941,7 +941,7 @@ static void bdi_update_dirty_ratelimit(struct backing_dev_info *bdi,
* feel and care are stable dirty rate and small position error.
*
* |task_ratelimit - dirty_ratelimit| is used to limit the step size
- * and filter out the sigular points of balanced_dirty_ratelimit. Which
+ * and filter out the singular points of balanced_dirty_ratelimit. Which
* keeps jumping around randomly and can even leap far away at times
* due to the small 200ms estimation period of dirty_rate (we want to
* keep that period small to reduce time lags).
--
1.7.9.5

2012-06-09 11:54:20

by Fengguang Wu

Subject: Re: [PATCH] mm/page-writeback.c: fix comments error in page-writeback.c

On Sat, Jun 09, 2012 at 07:45:33PM +0800, Wanpeng Li wrote:
> From: Wanpeng Li <[email protected]>
>
> Signed-off-by: Wanpeng Li <[email protected]>
> ---
> mm/page-writeback.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index 93d8d2f..c833bf0 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -930,7 +930,7 @@ static void bdi_update_dirty_ratelimit(struct backing_dev_info *bdi,
> */
>
> /*
> - * dirty_ratelimit will follow balanced_dirty_ratelimit iff
> + * dirty_ratelimit will follow balanced_dirty_ratelimit if

That 'iff' means 'if and only if'.

> * task_ratelimit is on the same side of dirty_ratelimit, too.
> * For example, when
> * - dirty_ratelimit > balanced_dirty_ratelimit
> @@ -941,7 +941,7 @@ static void bdi_update_dirty_ratelimit(struct backing_dev_info *bdi,
> * feel and care are stable dirty rate and small position error.
> *
> * |task_ratelimit - dirty_ratelimit| is used to limit the step size
> - * and filter out the sigular points of balanced_dirty_ratelimit. Which
> + * and filter out the singular points of balanced_dirty_ratelimit. Which
> * keeps jumping around randomly and can even leap far away at times
> * due to the small 200ms estimation period of dirty_rate (we want to
> * keep that period small to reduce time lags).

I'll fold the above chunk into the previous patch.

Thanks,
Fengguang