2012-06-09 12:02:41

by devendra.aaru

Subject: [PATCH 2/2] pinctrl: pinctrl-mxs: set platform driver data to NULL at errpath and at unregister

clear the platform data pointer when mxs_pinctrl_probe_dt fails,
and also before the unregistering with pinctrl subsystem.

Signed-off-by: Devendra Naga <[email protected]>
---
drivers/pinctrl/pinctrl-mxs.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/pinctrl/pinctrl-mxs.c b/drivers/pinctrl/pinctrl-mxs.c
index 9d46303..afb50ee 100644
--- a/drivers/pinctrl/pinctrl-mxs.c
+++ b/drivers/pinctrl/pinctrl-mxs.c
@@ -516,6 +516,7 @@ int __devinit mxs_pinctrl_probe(struct platform_device *pdev,
return 0;

err:
+ platform_set_drvdata(pdev, NULL);
iounmap(d->base);
return ret;
}
@@ -525,6 +526,7 @@ int __devexit mxs_pinctrl_remove(struct platform_device *pdev)
{
struct mxs_pinctrl_data *d = platform_get_drvdata(pdev);

+ platform_set_drvdata(pdev, NULL);
pinctrl_unregister(d->pctl);
iounmap(d->base);

--
1.7.9.5

2012-06-12 11:32:51

by Linus Walleij

Subject: Re: [PATCH 2/2] pinctrl: pinctrl-mxs: set platform driver data to NULL at errpath and at unregister

On Sat, Jun 9, 2012 at 2:02 PM, Devendra Naga <[email protected]> wrote:

> clear the platform data pointer when mxs_pinctrl_probe_dt fails,
> and also before the unregistering with pinctrl subsystem.
>
> Signed-off-by: Devendra Naga <[email protected]>

Applied this as well.

Yours,
Linus Walleij