2012-06-14 03:47:48

by Li Zhong

Subject: [PATCH][TRIVIAL] Fix comments in mm/memblock.c

Make the parameter names in comments consistent with the actual ones
used in the function.

Signed-off-by: Li Zhong <[email protected]>
---
mm/memblock.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/memblock.c b/mm/memblock.c
index 952123e..76cb09f 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -540,9 +540,9 @@ int __init_memblock memblock_reserve(phys_addr_t
base, phys_addr_t size)
* __next_free_mem_range - next function for for_each_free_mem_range()
* @idx: pointer to u64 loop variable
* @nid: nid: node selector, %MAX_NUMNODES for all nodes
- * @p_start: ptr to phys_addr_t for start address of the range, can be
%NULL
- * @p_end: ptr to phys_addr_t for end address of the range, can be %
NULL
- * @p_nid: ptr to int for nid of the range, can be %NULL
+ * @out_start: ptr to phys_addr_t for start address of the range, can
be %NULL
+ * @out_end: ptr to phys_addr_t for end address of the range, can be %
NULL
+ * @out_nid: ptr to int for nid of the range, can be %NULL
*
* Find the first free area from *@idx which matches @nid, fill the out
* parameters, and update *@idx for the next iteration. The lower
32bit of
--
1.7.9.5

2012-06-14 03:54:38

by Wanpeng Li

Subject: Re: [PATCH][TRIVIAL] Fix comments in mm/memblock.c

On Thu, Jun 14, 2012 at 11:47:30AM +0800, Li Zhong wrote:
>Make the parameter names in comments consistent with the actual ones
>used in the function.
>
>Signed-off-by: Li Zhong <[email protected]>
>---
> mm/memblock.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

Hi Li Zhong,

I have already send a path to fix this issues.
title is "mm:fix kernel-doc warnings"

Regards,
Wanpeng Li

>
>diff --git a/mm/memblock.c b/mm/memblock.c
>index 952123e..76cb09f 100644
>--- a/mm/memblock.c
>+++ b/mm/memblock.c
>@@ -540,9 +540,9 @@ int __init_memblock memblock_reserve(phys_addr_t
>base, phys_addr_t size)
> * __next_free_mem_range - next function for for_each_free_mem_range()
> * @idx: pointer to u64 loop variable
> * @nid: nid: node selector, %MAX_NUMNODES for all nodes
>- * @p_start: ptr to phys_addr_t for start address of the range, can be
>%NULL
>- * @p_end: ptr to phys_addr_t for end address of the range, can be %
>NULL
>- * @p_nid: ptr to int for nid of the range, can be %NULL
>+ * @out_start: ptr to phys_addr_t for start address of the range, can
>be %NULL
>+ * @out_end: ptr to phys_addr_t for end address of the range, can be %
>NULL
>+ * @out_nid: ptr to int for nid of the range, can be %NULL
> *
> * Find the first free area from *@idx which matches @nid, fill the out
> * parameters, and update *@idx for the next iteration. The lower
>32bit of
>--
>1.7.9.5
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to [email protected]
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/

2012-06-14 04:09:37

by Li Zhong

Subject: Re: [PATCH][TRIVIAL] Fix comments in mm/memblock.c

On Thu, 2012-06-14 at 11:54 +0800, Wanpeng Li wrote:
> On Thu, Jun 14, 2012 at 11:47:30AM +0800, Li Zhong wrote:
> >Make the parameter names in comments consistent with the actual ones
> >used in the function.
> >
> >Signed-off-by: Li Zhong <[email protected]>
> >---
> > mm/memblock.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Hi Li Zhong,
>
> I have already send a path to fix this issues.
> title is "mm:fix kernel-doc warnings"

Ah, ok.

Sorry for the noise ...

>
> Regards,
> Wanpeng Li
>
> >
> >diff --git a/mm/memblock.c b/mm/memblock.c
> >index 952123e..76cb09f 100644
> >--- a/mm/memblock.c
> >+++ b/mm/memblock.c
> >@@ -540,9 +540,9 @@ int __init_memblock memblock_reserve(phys_addr_t
> >base, phys_addr_t size)
> > * __next_free_mem_range - next function for for_each_free_mem_range()
> > * @idx: pointer to u64 loop variable
> > * @nid: nid: node selector, %MAX_NUMNODES for all nodes
> >- * @p_start: ptr to phys_addr_t for start address of the range, can be
> >%NULL
> >- * @p_end: ptr to phys_addr_t for end address of the range, can be %
> >NULL
> >- * @p_nid: ptr to int for nid of the range, can be %NULL
> >+ * @out_start: ptr to phys_addr_t for start address of the range, can
> >be %NULL
> >+ * @out_end: ptr to phys_addr_t for end address of the range, can be %
> >NULL
> >+ * @out_nid: ptr to int for nid of the range, can be %NULL
> > *
> > * Find the first free area from *@idx which matches @nid, fill the out
> > * parameters, and update *@idx for the next iteration. The lower
> >32bit of
> >--
> >1.7.9.5
> >
> >--
> >To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> >the body of a message to [email protected]
> >More majordomo info at http://vger.kernel.org/majordomo-info.html
> >Please read the FAQ at http://www.tux.org/lkml/
>