2012-06-14 05:55:35

by Axel Lin

[permalink] [raw]

Subject: [PATCH] regulator: tps65023: Fix mask for LDOs output voltage select control

---

According to the datasheet:
The LDO_CTRL registers are used to set the output voltage of LDO1 and LDO2.
LDO_CTRL[7] and LDO_CTRL[3] are reserved and should always be written to 0.

Thus the mask for TPS65023_LDO_1 and TPS65023_LDO_2 should be 0x07 and 0x70
respectively.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/tps65023-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/tps65023-regulator.c b/drivers/regulator/tps65023-regulator.c
index df8b70d..6fab428 100644
--- a/drivers/regulator/tps65023-regulator.c
+++ b/drivers/regulator/tps65023-regulator.c
@@ -71,7 +71,7 @@

/* LDO_CTRL bitfields */
#define TPS65023_LDO_CTRL_LDOx_SHIFT(ldo_id) ((ldo_id)*4)
-#define TPS65023_LDO_CTRL_LDOx_MASK(ldo_id) (0x0F << ((ldo_id)*4))
+#define TPS65023_LDO_CTRL_LDOx_MASK(ldo_id) (0x07 << ((ldo_id)*4))

/* Number of step-down converters available */
#define TPS65023_NUM_DCDC 3
--
1.7.9.5

2012-06-17 19:58:13

by Mark Brown

[permalink] [raw]

Subject: Re: [PATCH] regulator: tps65023: Fix mask for LDOs output voltage select control

---

On Thu, Jun 14, 2012 at 01:55:25PM +0800, Axel Lin wrote:
> According to the datasheet:
> The LDO_CTRL registers are used to set the output voltage of LDO1 and LDO2.
> LDO_CTRL[7] and LDO_CTRL[3] are reserved and should always be written to 0.

Applied, thanks.

---

Attachments:

(No filename) (262.00 B)
signature.asc (836.00 B)
Digital signature Download all attachments