From: Wanpeng Li <[email protected]>
Since lumpy reclaim algorithm is removed by Mel Gorman, cleanup the
footprint of lumpy reclaim.
Signed-off-by: Wanpeng Li <[email protected]>
---
mm/vmscan.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 603c96f..2fc16cf 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2065,8 +2065,9 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
* Try to write back as many pages as we just scanned. This
* tends to cause slow streaming writers to write data to the
* disk smoothly, at the dirtying rate, which is nice. But
- * that's undesirable in laptop mode, where we *want* lumpy
- * writeout. So in laptop mode, write out the whole world.
+ * that's undesirable in laptop mode, where as much I/O as
+ * possible should be trigged if the disk needs to be spun up.
+ * So in laptop mode, write out the whole world.
*/
writeback_threshold = sc->nr_to_reclaim + sc->nr_to_reclaim / 2;
if (total_scanned > writeback_threshold) {
--
1.7.9.5
On Fri, Jun 15, 2012 at 09:25:24AM +0800, Wanpeng Li wrote:
> From: Wanpeng Li <[email protected]>
>
> Since lumpy reclaim algorithm is removed by Mel Gorman, cleanup the
> footprint of lumpy reclaim.
I think the "lumpy writeout" here does not mean "lumpy reclaim" :-)
> @@ -2065,8 +2065,9 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
> * Try to write back as many pages as we just scanned. This
> * tends to cause slow streaming writers to write data to the
> * disk smoothly, at the dirtying rate, which is nice. But
> - * that's undesirable in laptop mode, where we *want* lumpy
> - * writeout. So in laptop mode, write out the whole world.
> + * that's undesirable in laptop mode, where as much I/O as
> + * possible should be trigged if the disk needs to be spun up.
> + * So in laptop mode, write out the whole world.
> */
> writeback_threshold = sc->nr_to_reclaim + sc->nr_to_reclaim / 2;
> if (total_scanned > writeback_threshold) {
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/