2012-06-16 17:45:45

by devendra.aaru

Subject: [PATCH] pinctrl/pinctrl-u300: remove devm_kfree at driver unload

the memory allocated by devm_kzalloc is automatically
freed at the driver detach side, so no neeed of calling
devm_kfree

Signed-off-by: Devendra Naga <[email protected]>
---
drivers/pinctrl/pinctrl-u300.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-u300.c b/drivers/pinctrl/pinctrl-u300.c
index 05d0299..13e7a3e 100644
--- a/drivers/pinctrl/pinctrl-u300.c
+++ b/drivers/pinctrl/pinctrl-u300.c
@@ -1183,7 +1183,6 @@ static int __devexit u300_pmx_remove(struct platform_device *pdev)
iounmap(upmx->virtbase);
release_mem_region(upmx->phybase, upmx->physize);
platform_set_drvdata(pdev, NULL);
- devm_kfree(&pdev->dev, upmx);

return 0;
}
--
1.7.9.5

2012-06-18 06:07:33

by Linus Walleij

Subject: Re: [PATCH] pinctrl/pinctrl-u300: remove devm_kfree at driver unload

On Sat, Jun 16, 2012 at 7:45 PM, Devendra Naga <[email protected]> wrote:

> the memory allocated by devm_kzalloc is automatically
> freed at the driver detach side, so no neeed of calling
> devm_kfree
>
> Signed-off-by: Devendra Naga <[email protected]>

Applied, thanks!
Linus Walleij