2012-06-18 17:47:30

by devendra.aaru

Subject: [PATCH] pinctrl/pinctrl-u300: remove unused variable i

the unused variable warning was thrown when compiled using the
gcc for ARM (arm-linux-gnueabihf-gcc) with u300_defconfig selected,

make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- u300_defconfig

and then

make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf-

gives the following warn,

drivers/pinctrl/pinctrl-u300.c: In function ‘u300_pmx_remove’:
drivers/pinctrl/pinctrl-u300.c:1178:6: warning: unused variable ‘i’ [-Wunused-variable]

Signed-off-by: Devendra Naga <[email protected]>
---
drivers/pinctrl/pinctrl-u300.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-u300.c b/drivers/pinctrl/pinctrl-u300.c
index 49b91c2..2ba13c5 100644
--- a/drivers/pinctrl/pinctrl-u300.c
+++ b/drivers/pinctrl/pinctrl-u300.c
@@ -1175,7 +1175,6 @@ out_no_resource:
static int __devexit u300_pmx_remove(struct platform_device *pdev)
{
struct u300_pmx *upmx = platform_get_drvdata(pdev);
- int i;

pinctrl_unregister(upmx->pctl);
iounmap(upmx->virtbase);
--
1.7.9.5

2012-06-20 08:00:50

by Linus Walleij

Subject: Re: [PATCH] pinctrl/pinctrl-u300: remove unused variable i

On Mon, Jun 18, 2012 at 7:47 PM, Devendra Naga <[email protected]> wrote:

> the unused variable warning was thrown when compiled using the
> gcc for ARM (arm-linux-gnueabihf-gcc) with u300_defconfig selected,
>
> make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- u300_defconfig
>
> and then
>
> make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf-
>
> gives the following warn,
>
> drivers/pinctrl/pinctrl-u300.c: In function ?u300_pmx_remove?:
> drivers/pinctrl/pinctrl-u300.c:1178:6: warning: unused variable ?i? [-Wunused-variable]
>
> Signed-off-by: Devendra Naga <[email protected]>

Incidentally I was working on this code and fixed the same issue,
but thanks anyway!

Yours,
Linus Walleij