2012-06-19 12:45:35

by devendra.aaru

[permalink] [raw]
Subject: [PATCH 1/3] staging/ft1000: Return -ENOMEM if kmalloc fails at ft1000_probe

If the kmalloc fails return -ENOMEM , returning 0 is not the proper
way if any function fails

Signed-off-by: Devendra Naga <[email protected]>
---
drivers/staging/ft1000/ft1000-usb/ft1000_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c b/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c
index 84c38d5..a07c504 100644
--- a/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c
+++ b/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c
@@ -71,7 +71,7 @@ static int ft1000_probe(struct usb_interface *interface,

if (!ft1000dev) {
printk(KERN_ERR "out of memory allocating device structure\n");
- return 0;
+ return -ENOMEM;
}

memset(ft1000dev, 0, sizeof(*ft1000dev));
--
1.7.9.5