2012-06-19 18:22:51

by devendra.aaru

Subject: [PATCH] leds: [trivial]Remove unnecesary return

the ret is got the status returned by the
led_classdev_register, returning ret if the
led_classdev_register fails and returning 0
if the led_classdev_register success, can be done
by doing just "return ret" at the end.

Signed-off-by: Devendra Naga <[email protected]>
---

Tested by build with the gcc linaro (arm-linux-gnueabihf) (4.7.1).

drivers/leds/leds-s3c24xx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/leds/leds-s3c24xx.c b/drivers/leds/leds-s3c24xx.c
index bd0a5ed..e6ee105 100644
--- a/drivers/leds/leds-s3c24xx.c
+++ b/drivers/leds/leds-s3c24xx.c
@@ -106,10 +106,9 @@ static int s3c24xx_led_probe(struct platform_device *dev)
if (ret < 0) {
dev_err(&dev->dev, "led_classdev_register failed\n");
kfree(led);
- return ret;
}

- return 0;
+ return ret;
}

static struct platform_driver s3c24xx_led_driver = {
--
1.7.9.5

2012-06-20 05:24:27

by Bryan Wu

Subject: Re: [PATCH] leds: [trivial]Remove unnecesary return

On Wed, Jun 20, 2012 at 2:22 AM, Devendra Naga <[email protected]> wrote:
> the ret is got the status returned by the
> led_classdev_register, returning ret if the
> led_classdev_register fails and returning 0
> if the led_classdev_register success, can be done
> by doing just "return ret" at the end.
>
> Signed-off-by: Devendra Naga <[email protected]>

Thanks, applied to my for-next branch.

-Bryan

> ---
>
> Tested by build with the gcc linaro (arm-linux-gnueabihf) (4.7.1).
>
> ?drivers/leds/leds-s3c24xx.c | ? ?3 +--
> ?1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-s3c24xx.c b/drivers/leds/leds-s3c24xx.c
> index bd0a5ed..e6ee105 100644
> --- a/drivers/leds/leds-s3c24xx.c
> +++ b/drivers/leds/leds-s3c24xx.c
> @@ -106,10 +106,9 @@ static int s3c24xx_led_probe(struct platform_device *dev)
> ? ? ? ?if (ret < 0) {
> ? ? ? ? ? ? ? ?dev_err(&dev->dev, "led_classdev_register failed\n");
> ? ? ? ? ? ? ? ?kfree(led);
> - ? ? ? ? ? ? ? return ret;
> ? ? ? ?}
>
> - ? ? ? return 0;
> + ? ? ? return ret;
> ?}
>
> ?static struct platform_driver s3c24xx_led_driver = {
> --
> 1.7.9.5



--
Bryan Wu <[email protected]>
Kernel Developer ? ?+86.186-168-78255 Mobile
Canonical Ltd. ? ? ?http://www.canonical.com
Ubuntu - Linux for human beings | http://www.ubuntu.com