2012-06-20 01:41:55

by Axel Lin

Subject: [PATCH] mfd: MFD_MAX77693 needs to select IRQ_DOMAIN

This fixes below build errors:

CC drivers/mfd/max77693-irq.o
drivers/mfd/max77693-irq.c: In function 'max77693_irq_thread':
drivers/mfd/max77693-irq.c:217:4: error: implicit declaration of function 'irq_find_mapping' [-Werror=implicit-function-declaration]
drivers/mfd/max77693-irq.c: In function 'max77693_irq_init':
drivers/mfd/max77693-irq.c:286:2: error: implicit declaration of function 'irq_domain_add_linear' [-Werror=implicit-function-declaration]
drivers/mfd/max77693-irq.c:286:9: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors
make[2]: *** [drivers/mfd/max77693-irq.o] Error 1
make[1]: *** [drivers/mfd] Error 2
make: *** [drivers] Error 2

Reported-by: Randy Dunlap <[email protected]>
Signed-off-by: Axel Lin <[email protected]>
---
drivers/mfd/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index e129c82..79f1d4b 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -427,6 +427,7 @@ config MFD_MAX77693
depends on I2C=y && GENERIC_HARDIRQS
select MFD_CORE
select REGMAP_I2C
+ select IRQ_DOMAIN
help
Say yes here to support for Maxim Semiconductor MAX77693.
This is a companion Power Management IC with Flash, Haptic, Charger,
--
1.7.9.5

2012-06-20 19:54:21

by Randy Dunlap

Subject: [PATCH] mfd: TWL6040_CORE needs to select IRQ_DOMAIN

From: Randy Dunlap <[email protected]>

Fix build error by selecting IRQ_DOMAIN:

drivers/mfd/twl6040-irq.c:164:2: error: implicit declaration of function 'irq_domain_add_legacy'
drivers/mfd/twl6040-irq.c:165:11: error: 'irq_domain_simple_ops' undeclared (first use in this function)

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Samuel Ortiz <[email protected]>
Cc: Misael Lopez Cruz <[email protected]>
---
drivers/mfd/Kconfig | 1 +
1 file changed, 1 insertion(+)

--- linux-next-20120620.orig/drivers/mfd/Kconfig
+++ linux-next-20120620/drivers/mfd/Kconfig
@@ -286,6 +286,7 @@ config TWL6040_CORE
depends on I2C=y && GENERIC_HARDIRQS
select MFD_CORE
select REGMAP_I2C
+ select IRQ_DOMAIN
default n
help
Say yes here if you want support for Texas Instruments TWL6040 audio

2012-06-20 19:54:41

by Randy Dunlap

Subject: Re: [PATCH] mfd: MFD_MAX77693 needs to select IRQ_DOMAIN

On 06/19/2012 06:40 PM, Axel Lin wrote:

> This fixes below build errors:
>
> CC drivers/mfd/max77693-irq.o
> drivers/mfd/max77693-irq.c: In function 'max77693_irq_thread':
> drivers/mfd/max77693-irq.c:217:4: error: implicit declaration of function 'irq_find_mapping' [-Werror=implicit-function-declaration]
> drivers/mfd/max77693-irq.c: In function 'max77693_irq_init':
> drivers/mfd/max77693-irq.c:286:2: error: implicit declaration of function 'irq_domain_add_linear' [-Werror=implicit-function-declaration]
> drivers/mfd/max77693-irq.c:286:9: warning: assignment makes pointer from integer without a cast [enabled by default]
> cc1: some warnings being treated as errors
> make[2]: *** [drivers/mfd/max77693-irq.o] Error 1
> make[1]: *** [drivers/mfd] Error 2
> make: *** [drivers] Error 2
>
> Reported-by: Randy Dunlap <[email protected]>
> Signed-off-by: Axel Lin <[email protected]>


Acked-by: Randy Dunlap <[email protected]>

Thanks.


> ---
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index e129c82..79f1d4b 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -427,6 +427,7 @@ config MFD_MAX77693
> depends on I2C=y && GENERIC_HARDIRQS
> select MFD_CORE
> select REGMAP_I2C
> + select IRQ_DOMAIN
> help
> Say yes here to support for Maxim Semiconductor MAX77693.
> This is a companion Power Management IC with Flash, Haptic, Charger,



--
~Randy