2012-06-23 02:52:08

by Daniel Lawrence

Subject: [PATCH] Staging: comedi: fixed printk coding style issue in acl7225b.c

This is a patch to the acl7225.b file that fixes up 2 printk warnings
found by the checkpatch.pl tool.
As this is a comedi driver the printk's have been changed to the
dev_printk style.

Signed-off-by: Daniel Lawrence <[email protected]>
---
drivers/staging/comedi/drivers/acl7225b.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/comedi/drivers/acl7225b.c b/drivers/staging/comedi/drivers/acl7225b.c
index 4e4fc41..ca74519 100644
--- a/drivers/staging/comedi/drivers/acl7225b.c
+++ b/drivers/staging/comedi/drivers/acl7225b.c
@@ -72,11 +72,11 @@ static int acl7225b_attach(struct comedi_device *dev,

iobase = it->options[0];
iorange = this_board->io_range;
- printk(KERN_INFO "comedi%d: acl7225b: board=%s 0x%04x\n", dev->minor,
+ dev_info(dev->class_dev, "acl7225b: board=%s 0x%04x\n",
this_board->name, iobase);
if (!request_region(iobase, iorange, "acl7225b")) {
- printk(KERN_ERR "comedi%d: request_region failed - I/O port conflict\n",
- dev->minor);
+ dev_err(dev->class_dev,
+ "request_region failed - I/O port conflict\n");
return -EIO;
}
dev->board_name = this_board->name;
--
1.7.9.5

2012-06-23 03:49:16

by Greg Kroah-Hartman

Subject: Re: [PATCH] Staging: comedi: fixed printk coding style issue in acl7225b.c

On Sat, Jun 23, 2012 at 12:51:43PM +1000, Daniel Lawrence wrote:
> This is a patch to the acl7225.b file that fixes up 2 printk warnings
> found by the checkpatch.pl tool.
> As this is a comedi driver the printk's have been changed to the
> dev_printk style.
>
> Signed-off-by: Daniel Lawrence <[email protected]>
> ---
> drivers/staging/comedi/drivers/acl7225b.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

As this is a "version 2" of this patch, next time please say so in the
subject so I know not to apply the first one. A simple:
Subject: [PATCH v2] ...
would suffice.

thanks,

greg k-h

2012-06-23 03:50:18

by Greg Kroah-Hartman

Subject: Re: [PATCH] Staging: comedi: fixed printk coding style issue in acl7225b.c

On Sat, Jun 23, 2012 at 12:51:43PM +1000, Daniel Lawrence wrote:
> This is a patch to the acl7225.b file that fixes up 2 printk warnings
> found by the checkpatch.pl tool.
> As this is a comedi driver the printk's have been changed to the
> dev_printk style.
>
> Signed-off-by: Daniel Lawrence <[email protected]>
> ---
> drivers/staging/comedi/drivers/acl7225b.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

This patch does not apply properly, what tree did you make it against?
Can you please redo it against the latest linux-next tree and resend it
so that I can apply it?

thanks,

greg k-h