2012-06-22 15:12:05

by Laxman Dewangan

Subject: [PATCH] dma: tegra: use sg_dma_address() for getting dma buffer address

Use the sg_dma_address() to get the segment buffer address for
DMA transfer in place of sg_phys() which returns the physical
address of an sg entry.
The sg_dma_address() returns the correct buffer memory address
for DMA transfer.

Signed-off-by: Laxman Dewangan <[email protected]>
---
drivers/dma/tegra20-apb-dma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
index 2e4c187..a46a21c 100644
--- a/drivers/dma/tegra20-apb-dma.c
+++ b/drivers/dma/tegra20-apb-dma.c
@@ -929,7 +929,7 @@ static struct dma_async_tx_descriptor *tegra_dma_prep_slave_sg(
for_each_sg(sgl, sg, sg_len, i) {
u32 len, mem;

- mem = sg_phys(sg);
+ mem = sg_dma_address(sg);
len = sg_dma_len(sg);

if ((len & 3) || (mem & 3) ||
--
1.7.1.1

2012-06-22 17:12:51

by Stephen Warren

Subject: Re: [PATCH] dma: tegra: use sg_dma_address() for getting dma buffer address

On 06/22/2012 09:11 AM, Laxman Dewangan wrote:
> Use the sg_dma_address() to get the segment buffer address for
> DMA transfer in place of sg_phys() which returns the physical
> address of an sg entry.
> The sg_dma_address() returns the correct buffer memory address
> for DMA transfer.

It's what everyone else is doing, so:
Acked-by: Stephen Warren <[email protected]>

2012-06-27 13:42:15

by Vinod Koul

Subject: Re: [PATCH] dma: tegra: use sg_dma_address() for getting dma buffer address

On Fri, 2012-06-22 at 11:12 -0600, Stephen Warren wrote:
> On 06/22/2012 09:11 AM, Laxman Dewangan wrote:
> > Use the sg_dma_address() to get the segment buffer address for
> > DMA transfer in place of sg_phys() which returns the physical
> > address of an sg entry.
> > The sg_dma_address() returns the correct buffer memory address
> > for DMA transfer.
>
> It's what everyone else is doing, so:
And this is the right thing to do.
> Acked-by: Stephen Warren <[email protected]>

Applied, thanks

--
~Vinod