2012-08-01 09:15:50

by Qiang Liu

Subject: [PATCH v5 6/6] fsl-dma: fix a warning of unitialized cookie

From: Qiang Liu <[email protected]>

Fix a warning of unitialized value when compile with -Wuninitialized.

Cc: Dan Williams <[email protected]>
Cc: Vinod Koul <[email protected]>
Cc: Li Yang <[email protected]>
Signed-off-by: Qiang Liu <[email protected]>
Reported-by: Kim Phillips <[email protected]>
---
drivers/dma/fsldma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
index e3814aa..6fc22eb 100644
--- a/drivers/dma/fsldma.c
+++ b/drivers/dma/fsldma.c
@@ -645,7 +645,7 @@ static dma_cookie_t fsl_dma_tx_submit(struct dma_async_tx_descriptor *tx)
struct fsldma_chan *chan = to_fsl_chan(tx->chan);
struct fsl_desc_sw *desc = tx_to_fsl_desc(tx);
struct fsl_desc_sw *child;
- dma_cookie_t cookie;
+ dma_cookie_t cookie = 0;

spin_lock_bh(&chan->desc_lock);

--
1.7.5.1

2012-08-01 17:26:04

by Ira W. Snyder

Subject: Re: [PATCH v5 6/6] fsl-dma: fix a warning of unitialized cookie

On Wed, Aug 01, 2012 at 04:50:27PM +0800, [email protected] wrote:
> From: Qiang Liu <[email protected]>
>
> Fix a warning of unitialized value when compile with -Wuninitialized.
>

Looks good to me.

Acked-by: Ira W. Snyder <[email protected]>

> Cc: Dan Williams <[email protected]>
> Cc: Vinod Koul <[email protected]>
> Cc: Li Yang <[email protected]>
> Signed-off-by: Qiang Liu <[email protected]>
> Reported-by: Kim Phillips <[email protected]>
> ---
> drivers/dma/fsldma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
> index e3814aa..6fc22eb 100644
> --- a/drivers/dma/fsldma.c
> +++ b/drivers/dma/fsldma.c
> @@ -645,7 +645,7 @@ static dma_cookie_t fsl_dma_tx_submit(struct dma_async_tx_descriptor *tx)
> struct fsldma_chan *chan = to_fsl_chan(tx->chan);
> struct fsl_desc_sw *desc = tx_to_fsl_desc(tx);
> struct fsl_desc_sw *child;
> - dma_cookie_t cookie;
> + dma_cookie_t cookie = 0;
>
> spin_lock_bh(&chan->desc_lock);
>
> --
> 1.7.5.1
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> [email protected]
> https://lists.ozlabs.org/listinfo/linuxppc-dev