2012-08-02 07:04:00

by Sachin Kamat

[permalink] [raw]
Subject: [PATCH] pwm: Add missing static storage class specifiers in core.c file

Fixes the following sparse warnings:
drivers/pwm/core.c:152:6: warning:
symbol 'of_pwmchip_add' was not declared. Should it be static?
drivers/pwm/core.c:165:6: warning:
symbol 'of_pwmchip_remove' was not declared. Should it be static?

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/pwm/core.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index ecb7690..4a8bdfa 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -149,7 +149,7 @@ static struct pwm_device *of_pwm_simple_xlate(struct pwm_chip *pc,
return pwm;
}

-void of_pwmchip_add(struct pwm_chip *chip)
+static void of_pwmchip_add(struct pwm_chip *chip)
{
if (!chip->dev || !chip->dev->of_node)
return;
@@ -162,7 +162,7 @@ void of_pwmchip_add(struct pwm_chip *chip)
of_node_get(chip->dev->of_node);
}

-void of_pwmchip_remove(struct pwm_chip *chip)
+static void of_pwmchip_remove(struct pwm_chip *chip)
{
if (chip->dev && chip->dev->of_node)
of_node_put(chip->dev->of_node);
--
1.7.4.1


2012-08-02 07:35:36

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH] pwm: Add missing static storage class specifiers in core.c file

On Thu, Aug 02, 2012 at 12:32:42PM +0530, Sachin Kamat wrote:
> Fixes the following sparse warnings:
> drivers/pwm/core.c:152:6: warning:
> symbol 'of_pwmchip_add' was not declared. Should it be static?
> drivers/pwm/core.c:165:6: warning:
> symbol 'of_pwmchip_remove' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <[email protected]>

Applied, thanks.

Thierry


Attachments:
(No filename) (394.00 B)
(No filename) (836.00 B)
Download all attachments

2012-08-09 05:49:12

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH] pwm: Add missing static storage class specifiers in core.c file

On Thu, Aug 02, 2012 at 12:32:42PM +0530, Sachin Kamat wrote:
> Fixes the following sparse warnings:
> drivers/pwm/core.c:152:6: warning:
> symbol 'of_pwmchip_add' was not declared. Should it be static?
> drivers/pwm/core.c:165:6: warning:
> symbol 'of_pwmchip_remove' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <[email protected]>
> ---
> drivers/pwm/core.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Thierry


Attachments:
(No filename) (486.00 B)
(No filename) (836.00 B)
Download all attachments