2012-08-02 19:42:11

by Peter Jones

[permalink] [raw]
Subject: [PATCH] MODSIGN: Fix documentation of signed-nokey behavior when not enforcing.

jwboyer's previous commit changes the behavior of module signing when
there's a valid signature but we don't know the public key and are in
permissive mode. This updates the documentation to match.
---
Documentation/module-signing.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/module-signing.txt b/Documentation/module-signing.txt
index d75d473..8c4bef9 100644
--- a/Documentation/module-signing.txt
+++ b/Documentation/module-signing.txt
@@ -185,7 +185,7 @@ This table indicates the behaviours of the various situations:
MODULE STATE PERMISSIVE MODE ENFORCING MODE
======================================= =============== ===============
Unsigned Ok EKEYREJECTED
- Signed, no public key ENOKEY ENOKEY
+ Signed, no public key Ok ENOKEY
Validly signed, public key Ok Ok
Invalidly signed, public key EKEYREJECTED EKEYREJECTED
Validly signed, expired key EKEYEXPIRED EKEYEXPIRED
--
1.7.11.2


2012-08-02 19:46:59

by Josh Boyer

[permalink] [raw]
Subject: Re: [PATCH] MODSIGN: Fix documentation of signed-nokey behavior when not enforcing.

On Thu, Aug 02, 2012 at 03:41:58PM -0400, Peter Jones wrote:
> jwboyer's previous commit changes the behavior of module signing when
> there's a valid signature but we don't know the public key and are in
> permissive mode. This updates the documentation to match.
> ---

Missing a S-o-B, but otherwise:

Acked-by: Josh Boyer <[email protected]>

> Documentation/module-signing.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/module-signing.txt b/Documentation/module-signing.txt
> index d75d473..8c4bef9 100644
> --- a/Documentation/module-signing.txt
> +++ b/Documentation/module-signing.txt
> @@ -185,7 +185,7 @@ This table indicates the behaviours of the various situations:
> MODULE STATE PERMISSIVE MODE ENFORCING MODE
> ======================================= =============== ===============
> Unsigned Ok EKEYREJECTED
> - Signed, no public key ENOKEY ENOKEY
> + Signed, no public key Ok ENOKEY
> Validly signed, public key Ok Ok
> Invalidly signed, public key EKEYREJECTED EKEYREJECTED
> Validly signed, expired key EKEYEXPIRED EKEYEXPIRED
> --
> 1.7.11.2
>