2012-08-04 07:15:25

by Devendra Naga

Subject: [PATCH 0/5] staging/csr: cleanup patches

Hi Greg,

These patches does

* coding style fixes
* little cleanups like unneeded initialisations and
comparing a bool against 1 in if

each and every patch is compile tested on top of the previous one

Thanks,

----------------------------

Actually i have a question about the dbg macros, unifi_warning,
unifi_error, and unifi_trace,

I think these can be implemented using dev_warn, dev_dbg, functions,
i mean we can remove these unifi_warning and unifi_error and unifi_trace
and use the dev_warn and dev_dbg.

Please correct me if i am wrong

Devendra Naga (5):
staging/csr: clean coding style in uf_start_thread
staging/csr: fix coding style problems in uf_stop_thread
staging/csr: fix coding style problems in uf_wait_for_thread_to_stop
staging/csr: remove the initialisation of interfaceTag and its
comment in handle_bh_error
staging/csr: fix coding style problems in handle_bh_error

drivers/staging/csr/bh.c | 173 ++++++++++++++++++++++++----------------------
1 file changed, 90 insertions(+), 83 deletions(-)

Signed-off-by: Devendra Naga <[email protected]>
--
1.7.9.5

2012-08-14 01:58:37

by Greg Kroah-Hartman

Subject: Re: [PATCH 0/5] staging/csr: cleanup patches

On Sat, Aug 04, 2012 at 01:00:08PM +0545, Devendra Naga wrote:
> Actually i have a question about the dbg macros, unifi_warning,
> unifi_error, and unifi_trace,
>
> I think these can be implemented using dev_warn, dev_dbg, functions,
> i mean we can remove these unifi_warning and unifi_error and unifi_trace
> and use the dev_warn and dev_dbg.

Yes, we should use those instead.

thanks,

greg k-h