2012-08-04 19:31:35

by Silviu-Mihai Popescu

Subject: [PATCH] tcp_output: fix sparse warning for tcp_wfree

Fix sparse warning:
* symbol 'tcp_wfree' was not declared. Should it be static?

Signed-off-by: Silviu-Mihai Popescu <[email protected]>
---
net/ipv4/tcp_output.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
index 3f1bcff..18475e0 100644
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -940,7 +940,7 @@ void __init tcp_tasklet_init(void)
* We cant xmit new skbs from this context, as we might already
* hold qdisc lock.
*/
-void tcp_wfree(struct sk_buff *skb)
+static void tcp_wfree(struct sk_buff *skb)
{
struct sock *sk = skb->sk;
struct tcp_sock *tp = tcp_sk(sk);
--
1.7.9.5

2012-08-06 20:30:11

by David Miller

Subject: Re: [PATCH] tcp_output: fix sparse warning for tcp_wfree

From: Silviu-Mihai Popescu <[email protected]>
Date: Sat, 4 Aug 2012 22:31:29 +0300

> Fix sparse warning:
> * symbol 'tcp_wfree' was not declared. Should it be static?
>
> Signed-off-by: Silviu-Mihai Popescu <[email protected]>

Applied.