2012-08-08 20:14:48

by Marek Belisko

Subject: [PATCH] staging:ccg: Fix missing brackets for sizeof (found by sparse).

Fix following:
WARNING: sizeof fsg should be sizeof(fsg)
+ memset(&fsg, 0, sizeof fsg);

Signed-off-by: Marek Belisko <[email protected]>
---
drivers/staging/ccg/ccg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ccg/ccg.c b/drivers/staging/ccg/ccg.c
index 6a7aab8..81ac6bb 100644
--- a/drivers/staging/ccg/ccg.c
+++ b/drivers/staging/ccg/ccg.c
@@ -728,7 +728,7 @@ static int mass_storage_function_init(struct ccg_usb_function *f,
struct fsg_common *common;
int err;

- memset(&fsg, 0, sizeof fsg);
+ memset(&fsg, 0, sizeof(fsg));
fsg.nluns = 1;
fsg.luns[0].removable = 1;
fsg.vendor_name = iManufacturer;
--
1.7.9.5

2012-08-08 20:22:26

by Jesper Juhl

Subject: Re: [PATCH] staging:ccg: Fix missing brackets for sizeof (found by sparse).

On Wed, 8 Aug 2012, Marek Belisko wrote:

> Fix following:
> WARNING: sizeof fsg should be sizeof(fsg)
> + memset(&fsg, 0, sizeof fsg);
>
> Signed-off-by: Marek Belisko <[email protected]>
> ---
> drivers/staging/ccg/ccg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ccg/ccg.c b/drivers/staging/ccg/ccg.c
> index 6a7aab8..81ac6bb 100644
> --- a/drivers/staging/ccg/ccg.c
> +++ b/drivers/staging/ccg/ccg.c
> @@ -728,7 +728,7 @@ static int mass_storage_function_init(struct ccg_usb_function *f,
> struct fsg_common *common;
> int err;
>
> - memset(&fsg, 0, sizeof fsg);
> + memset(&fsg, 0, sizeof(fsg));
> fsg.nluns = 1;
> fsg.luns[0].removable = 1;
> fsg.vendor_name = iManufacturer;
>
Looks good to me.

Reviewed-by: Jesper Juhl <[email protected]>


--
Jesper Juhl <[email protected]> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.