2012-08-13 17:28:42

by Justin P. Mattock

[permalink] [raw]
Subject: [PATCH v2]staging "vme" Fix typos.

From: "Justin P. Mattock" <[email protected]>

Signed-off-by: Justin P. Mattock <[email protected]>

---
Note:resend with minor adjustments.
The below patch fixes typos found while reading through staging "vme"

drivers/staging/vme/devices/vme_user.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
index e25645e..0170788 100644
--- a/drivers/staging/vme/devices/vme_user.c
+++ b/drivers/staging/vme/devices/vme_user.c
@@ -64,13 +64,13 @@ static unsigned int bus_num;
*
* However the VME driver at http://www.vmelinux.org/ is rather old and doesn't
* even support the tsi148 chipset (which has 8 master and 8 slave windows).
- * We'll run with this or now as far as possible, however it probably makes
+ * We'll run with this for now as far as possible, however it probably makes
* sense to get rid of the old mappings and just do everything dynamically.
*
* So for now, we'll restrict the driver to providing 4 masters and 4 slaves as
* defined above and try to support at least some of the interface from
- * http://www.vmelinux.org/ as an alternative drive can be written providing a
- * saner interface later.
+ * http://www.vmelinux.org/ as an alternative the driver can be written
+ * providing a saner interface later.
*
* The vmelinux.org driver never supported slave images, the devices reserved
* for slaves were repurposed to support all 8 master images on the UniverseII!
@@ -242,7 +242,7 @@ static ssize_t resource_to_user(int minor, char __user *buf, size_t count,
}

/*
- * We are going ot alloc a page during init per window for small transfers.
+ * We are going to alloc a page during init per window for small transfers.
* Small transfers will go user space -> buffer -> VME. Larger (more than a
* page) transfers will lock the user space buffer into memory and then
* transfer the data directly from the user space buffers out to VME.
--
1.7.5.4


2012-08-14 09:14:06

by Martyn Welch

[permalink] [raw]
Subject: Re: [PATCH v2]staging "vme" Fix typos.

On 13/08/12 18:28, Justin P. Mattock wrote:
> From: "Justin P. Mattock" <[email protected]>
>
> Signed-off-by: Justin P. Mattock <[email protected]>
>
> ---
> Note:resend with minor adjustments.
> The below patch fixes typos found while reading through staging "vme"
>
> drivers/staging/vme/devices/vme_user.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
> index e25645e..0170788 100644
> --- a/drivers/staging/vme/devices/vme_user.c
> +++ b/drivers/staging/vme/devices/vme_user.c
> @@ -64,13 +64,13 @@ static unsigned int bus_num;
> *
> * However the VME driver at http://www.vmelinux.org/ is rather old and doesn't
> * even support the tsi148 chipset (which has 8 master and 8 slave windows).
> - * We'll run with this or now as far as possible, however it probably makes
> + * We'll run with this for now as far as possible, however it probably makes
> * sense to get rid of the old mappings and just do everything dynamically.
> *
> * So for now, we'll restrict the driver to providing 4 masters and 4 slaves as
> * defined above and try to support at least some of the interface from
> - * http://www.vmelinux.org/ as an alternative drive can be written providing a
> - * saner interface later.
> + * http://www.vmelinux.org/ as an alternative the driver can be written
> + * providing a saner interface later.
> *
> * The vmelinux.org driver never supported slave images, the devices reserved
> * for slaves were repurposed to support all 8 master images on the UniverseII!
> @@ -242,7 +242,7 @@ static ssize_t resource_to_user(int minor, char __user *buf, size_t count,
> }
>
> /*
> - * We are going ot alloc a page during init per window for small transfers.
> + * We are going to alloc a page during init per window for small transfers.
> * Small transfers will go user space -> buffer -> VME. Larger (more than a
> * page) transfers will lock the user space buffer into memory and then
> * transfer the data directly from the user space buffers out to VME.
>

Thanks for updating the patch, that's much better:

Acked-by: Martyn Welch <[email protected]>

--
Martyn Welch (Lead Software Engineer) | Registered in England and Wales
GE Intelligent Platforms | (3828642) at 100 Barbirolli Square
T +44(0)1327322748 | Manchester, M2 3AB
E [email protected] | VAT:GB 927559189