On Thu, 2012-07-12 at 14:22 +0200, Roland Stigge wrote:
> This patch adjusts the LPC32xx SLC NAND driver to the new pl08x DMA interface,
> fixing the compile error resulting from changed pl08x structures.
>
> Signed-off-by: Roland Stigge <[email protected]>
This patch breaks compilation:
ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko] undefined!
Please, send a fix. The defconfig I used is attached.
--
Best Regards,
Artem Bityutskiy
Hi,
On 08/15/2012 12:37 PM, Artem Bityutskiy wrote:
> On Thu, 2012-07-12 at 14:22 +0200, Roland Stigge wrote:
>> This patch adjusts the LPC32xx SLC NAND driver to the new pl08x
>> DMA interface, fixing the compile error resulting from changed
>> pl08x structures.
>>
>> Signed-off-by: Roland Stigge <[email protected]>
>
> This patch breaks compilation:
>
> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko]
> undefined!
>
> Please, send a fix. The defconfig I used is attached.
Thanks for the note. The issue happens on compiling lpc32xx_slc and
lpc32xx_mlc as a module. Caused by pl08x_filter_id not being exported.
Looking at other dma drivers, they have an EXPORT_SYMBOL() for this,
see also
drivers/dma/coh901318.c
drivers/dma/sirf-dma.c
Will post a respective adjustment for drivers/dma/amba-pl08x.c separately.
Roland
Hi,
On 08/15/2012 12:37 PM, Artem Bityutskiy wrote:
> On Thu, 2012-07-12 at 14:22 +0200, Roland Stigge wrote:
>> This patch adjusts the LPC32xx SLC NAND driver to the new pl08x
>> DMA interface, fixing the compile error resulting from changed
>> pl08x structures.
>>
>> Signed-off-by: Roland Stigge <[email protected]>
>
> This patch breaks compilation:
>
> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko]
> undefined!
>
> Please, send a fix. The defconfig I used is attached.
Please see my just posted patches:
mtd: lpc32xx_slc: Make driver independent of AMBA DMA engine driver
mtd: lpc32xx_mlc: Make driver independent of AMBA DMA engine driver
This also fixes the above problem by getting rid of the reference to
pl08x_filter_id.
Thanks,
Roland