2012-08-16 04:32:59

by Axel Lin

Subject: [PATCH] regulator: max8907: Fix n_voltages for MAX8907B SD1

For linear voltage mapping, the n_voltages is (max - min) / step + 1

Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/max8907-regulator.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/regulator/max8907-regulator.c b/drivers/regulator/max8907-regulator.c
index bd3b28b..bdf21a1 100644
--- a/drivers/regulator/max8907-regulator.c
+++ b/drivers/regulator/max8907-regulator.c
@@ -286,7 +286,8 @@ static __devinit int max8907_regulator_probe(struct platform_device *pdev)
MAX8907_II2RR_VERSION_REV_B) {
pmic->desc[MAX8907_SD1].min_uV = 637500;
pmic->desc[MAX8907_SD1].uV_step = 12500;
- pmic->desc[MAX8907_SD1].n_voltages = (1425000 - 637500) / 12500;
+ pmic->desc[MAX8907_SD1].n_voltages =
+ (1425000 - 637500) / 12500 + 1;
}

for (i = 0; i < MAX8907_NUM_REGULATORS; i++) {
--
1.7.9.5

2012-08-16 16:06:23

by Stephen Warren

Subject: Re: [PATCH] regulator: max8907: Fix n_voltages for MAX8907B SD1

On 08/15/2012 10:26 PM, Axel Lin wrote:
> For linear voltage mapping, the n_voltages is (max - min) / step + 1

Oh yes:-(

Acked-by: Stephen Warren <[email protected]>

2012-08-17 22:01:28

by Mark Brown

Subject: Re: [PATCH] regulator: max8907: Fix n_voltages for MAX8907B SD1

On Thu, Aug 16, 2012 at 12:26:02PM +0800, Axel Lin wrote:
> For linear voltage mapping, the n_voltages is (max - min) / step + 1

Applied, thanks.