2012-08-16 15:19:52

by Shubhrajyoti D

Subject: [PATCH] spi: omap2-mcspi: Remove the call to platform_set_drvdata(pdev, NULL)

Remove the call of platform_set_drvdata(pdev, NULL) as they are not
needed anymore.

Signed-off-by: Shubhrajyoti D <[email protected]>
---
drivers/spi/spi-omap2-mcspi.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
index bc47781..84aeaf0 100644
--- a/drivers/spi/spi-omap2-mcspi.c
+++ b/drivers/spi/spi-omap2-mcspi.c
@@ -1240,7 +1240,6 @@ dma_chnl_free:
kfree(mcspi->dma_channels);
free_master:
kfree(master);
- platform_set_drvdata(pdev, NULL);
return status;
}

@@ -1259,7 +1258,6 @@ static int __devexit omap2_mcspi_remove(struct platform_device *pdev)

spi_unregister_master(master);
kfree(dma_channels);
- platform_set_drvdata(pdev, NULL);

return 0;
}
--
1.7.5.4

2012-08-17 21:57:05

by Mark Brown

Subject: Re: [PATCH] spi: omap2-mcspi: Remove the call to platform_set_drvdata(pdev, NULL)

On Thu, Aug 16, 2012 at 08:49:30PM +0530, Shubhrajyoti D wrote:
> Remove the call of platform_set_drvdata(pdev, NULL) as they are not
> needed anymore.

Applied, thanks. These calls were never *needed* people just like to
put them in.