2012-08-17 15:40:05

by Shirley Ma

[permalink] [raw]
Subject: Re: [RFC PATCH 0/1] sched: Add a new API to find the prefer idlest cpu

Hello Ingo, Peter,

Have you had chance to review below patch?

Thanks
Shirley

On Sun, 2012-07-22 at 23:57 -0700, Shirley Ma wrote:
> Introduce a new API to choose per-cpu thread from cgroup control cpuset
> (allowed) and preferred cpuset (local numa-node).
>
> The receiving cpus of a networking device are not under cgroup controls.
> When such a networking device uses per-cpu thread model, the cpu which
> is chose to process the packets might not be part of cgroup cpusets
> without this API. On numa system, the preferred cpusets would help to
> reduce expensive cross memory access to/from the other node.
>
> Signed-off-by: Shirley Ma <[email protected]>
> ---
>
> include/linux/sched.h | 2 ++
> kernel/sched/fair.c | 30 ++++++++++++++++++++++++++++++
> 2 files changed, 32 insertions(+), 0 deletions(-)
>
> Thanks
> Shirley
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>


2012-08-17 16:49:16

by Peter Zijlstra

[permalink] [raw]
Subject: Re: [RFC PATCH 0/1] sched: Add a new API to find the prefer idlest cpu

On Fri, 2012-08-17 at 08:39 -0700, Shirley Ma wrote:

> Hello Ingo, Peter,
> Have you had chance to review below patch?

Well no of course not, nobody CC'ed us..

Your patch submission sucks, you split the changelog and the actual
patch into two different emails.

It doesn't mention who would be calling this and how often. Nor does it
seem to explain where the cpumask arguments come from.

Please try again.

2012-08-17 16:58:29

by Shirley Ma

[permalink] [raw]
Subject: Re: [RFC PATCH 0/1] sched: Add a new API to find the prefer idlest cpu

On Fri, 2012-08-17 at 18:48 +0200, Peter Zijlstra wrote:
> On Fri, 2012-08-17 at 08:39 -0700, Shirley Ma wrote:
>
> > Hello Ingo, Peter,
> > Have you had chance to review below patch?
>
> Well no of course not, nobody CC'ed us..
>
> Your patch submission sucks, you split the changelog and the actual
> patch into two different emails.
>
> It doesn't mention who would be calling this and how often. Nor does
> it
> seem to explain where the cpumask arguments come from.
>
> Please try again.

Thanks for your comments. I must be spoiled by net-dev maintainers. I
used to submit the patch this way thought my linux email in the past
many years. So I need to reply on the changelog for the actual patch? I
hope I won't make any more suck submissions again.

I will try to explain more details why this API needs to be exported.

Thanks again.
Shirley