2012-08-18 06:33:29

by Axel Lin

[permalink] [raw]
Subject: [PATCH] regulator: max8907: Properly set pmic pointer in max8907_regulator_remove()

Add missing platform_get_drvdata() call in max8907_regulator_remove(), this
fixes below build warning:

CC [M] drivers/regulator/max8907-regulator.o
drivers/regulator/max8907-regulator.c: In function 'max8907_regulator_remove':
drivers/regulator/max8907-regulator.c:353:23: warning: 'pmic' is used uninitialized in this function [-Wuninitialized]

Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/max8907-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/max8907-regulator.c b/drivers/regulator/max8907-regulator.c
index bd3b28b..831488f 100644
--- a/drivers/regulator/max8907-regulator.c
+++ b/drivers/regulator/max8907-regulator.c
@@ -346,7 +346,7 @@ err_unregister_regulator:

static __devexit int max8907_regulator_remove(struct platform_device *pdev)
{
- struct max8907_regulator *pmic;
+ struct max8907_regulator *pmic = platform_get_drvdata(pdev);
int i;

for (i = 0; i < MAX8907_NUM_REGULATORS; i++)
--
1.7.9.5



2012-08-20 15:01:48

by Stephen Warren

[permalink] [raw]
Subject: Re: [PATCH] regulator: max8907: Properly set pmic pointer in max8907_regulator_remove()

On 08/18/2012 12:33 AM, Axel Lin wrote:
> Add missing platform_get_drvdata() call in max8907_regulator_remove(), this
> fixes below build warning:
>
> CC [M] drivers/regulator/max8907-regulator.o
> drivers/regulator/max8907-regulator.c: In function 'max8907_regulator_remove':
> drivers/regulator/max8907-regulator.c:353:23: warning: 'pmic' is used uninitialized in this function [-Wuninitialized]

That's odd; while this warning and the patch are obviously correct, I
can't get my compiler to warn about it at all, and it usually is pretty
strict about emitting warnings. Oh well.

Acked-by: Stephen Warren <[email protected]>

2012-08-20 19:59:01

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulator: max8907: Properly set pmic pointer in max8907_regulator_remove()

On Sat, Aug 18, 2012 at 02:33:05PM +0800, Axel Lin wrote:
> Add missing platform_get_drvdata() call in max8907_regulator_remove(), this
> fixes below build warning:

Applied, thanks.

Attachments:
(No filename) (183.00 B)
 signature.asc (836.00 B)
Digital signature Download all attachments

2012-08-21 03:37:06

by Axel Lin

[permalink] [raw]
Subject: Re: [PATCH] regulator: max8907: Properly set pmic pointer in max8907_regulator_remove()

2012/8/20 Stephen Warren <[email protected]>:
> On 08/18/2012 12:33 AM, Axel Lin wrote:
>> Add missing platform_get_drvdata() call in max8907_regulator_remove(), this
>> fixes below build warning:
>>
>> CC [M] drivers/regulator/max8907-regulator.o
>> drivers/regulator/max8907-regulator.c: In function 'max8907_regulator_remove':
>> drivers/regulator/max8907-regulator.c:353:23: warning: 'pmic' is used uninitialized in this function [-Wuninitialized]
>
> That's odd; while this warning and the patch are obviously correct, I
> can't get my compiler to warn about it at all, and it usually is pretty
> strict about emitting warnings. Oh well.

I got this error message only when I compile it as a module. :-)

Axel