2012-08-20 21:02:32

by Corentin Chary

Subject: [PATCH 2/3] asus-laptop: HRWS/HWRS typo

Signed-off-by: Corentin Chary <[email protected]>
---
drivers/platform/x86/asus-laptop.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
index e38f91b..110c777 100644
--- a/drivers/platform/x86/asus-laptop.c
+++ b/drivers/platform/x86/asus-laptop.c
@@ -863,9 +863,9 @@ static ssize_t show_infos(struct device *dev,
* The significance of others is yet to be found.
* If we don't find the method, we assume the device are present.
*/
- rv = acpi_evaluate_integer(asus->handle, "HRWS", NULL, &temp);
+ rv = acpi_evaluate_integer(asus->handle, "HWRS", NULL, &temp);
if (!ACPI_FAILURE(rv))
- len += sprintf(page + len, "HRWS value : %#x\n",
+ len += sprintf(page + len, "HWRS value : %#x\n",
(uint) temp);
/*
* Another value for userspace: the ASYM method returns 0x02 for
@@ -1751,9 +1751,9 @@ static int asus_laptop_get_info(struct asus_laptop *asus)
* The significance of others is yet to be found.
*/
status =
- acpi_evaluate_integer(asus->handle, "HRWS", NULL, &hwrs_result);
+ acpi_evaluate_integer(asus->handle, "HWRS", NULL, &hwrs_result);
if (!ACPI_FAILURE(status))
- pr_notice(" HRWS returned %x", (int)hwrs_result);
+ pr_notice(" HWRS returned %x", (int)hwrs_result);

if (!acpi_check_handle(asus->handle, METHOD_WL_STATUS, NULL))
asus->have_rsts = true;
--
1.7.9.5

2012-08-20 21:06:59

by Alan

Subject: Re: [PATCH 2/3] asus-laptop: HRWS/HWRS typo

On Mon, 20 Aug 2012 23:01:51 +0200
Corentin Chary <[email protected]> wrote:

> Signed-off-by: Corentin Chary <[email protected]>
> ---
> drivers/platform/x86/asus-laptop.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index e38f91b..110c777 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -863,9 +863,9 @@ static ssize_t show_infos(struct device *dev,
> * The significance of others is yet to be found.
> * If we don't find the method, we assume the device are present.
> */
> - rv = acpi_evaluate_integer(asus->handle, "HRWS", NULL, &temp);
> + rv = acpi_evaluate_integer(asus->handle, "HWRS", NULL, &temp);
> if (!ACPI_FAILURE(rv))
> - len += sprintf(page + len, "HRWS value : %#x\n",
> + len += sprintf(page + len, "HWRS value : %#x\n",
> (uint) temp);
> /*
> * Another value for userspace: the ASYM method returns 0x02 for
> @@ -1751,9 +1751,9 @@ static int asus_laptop_get_info(struct asus_laptop *asus)
> * The significance of others is yet to be found.
> */
> status =
> - acpi_evaluate_integer(asus->handle, "HRWS", NULL, &hwrs_result);
> + acpi_evaluate_integer(asus->handle, "HWRS", NULL, &hwrs_result);
> if (!ACPI_FAILURE(status))
> - pr_notice(" HRWS returned %x", (int)hwrs_result);
> + pr_notice(" HWRS returned %x", (int)hwrs_result);
>
> if (!acpi_check_handle(asus->handle, METHOD_WL_STATUS, NULL))
> asus->have_rsts = true;

Please also tag this commit

Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=24222

so we can track it back out of bugzilla.