2012-08-21 09:37:24

by Axel Lin

Subject: [PATCH] gpio: bt8xx: Fix build error due to missing include file

This patch fixes below build error:

CC [M] drivers/gpio/gpio-bt8xx.o
drivers/gpio/gpio-bt8xx.c:53:40: fatal error: ../media/video/bt8xx/bt848.h: No such file or directory
compilation terminated.
make[2]: *** [drivers/gpio/gpio-bt8xx.o] Error 1
make[1]: *** [drivers/gpio] Error 2
make: *** [drivers] Error 2

drivers/media/video/bt8xx/bt848.h is moved to drivers/media/pci/bt8xx/bt848.h
by commit 68de959f773a1d49096835c411390bceff5d1549
"[media] bt8xx: move analog TV part to be together with DTV one".

Signed-off-by: Axel Lin <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
---
drivers/gpio/gpio-bt8xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-bt8xx.c b/drivers/gpio/gpio-bt8xx.c
index e4cc7eb..92d555d 100644
--- a/drivers/gpio/gpio-bt8xx.c
+++ b/drivers/gpio/gpio-bt8xx.c
@@ -50,7 +50,7 @@
#include <linux/slab.h>

/* Steal the hardware definitions from the bttv driver. */
-#include "../media/video/bt8xx/bt848.h"
+#include "../media/pci/bt8xx/bt848.h"


#define BT8XXGPIO_NR_GPIOS 24 /* We have 24 GPIO pins */
--
1.7.9.5

2012-08-21 11:23:48

by Mauro Carvalho Chehab

Subject: Re: [PATCH] gpio: bt8xx: Fix build error due to missing include file

Hi Axel,

Em 21-08-2012 06:37, Axel Lin escreveu:
> This patch fixes below build error:
>
> CC [M] drivers/gpio/gpio-bt8xx.o
> drivers/gpio/gpio-bt8xx.c:53:40: fatal error: ../media/video/bt8xx/bt848.h: No such file or directory
> compilation terminated.
> make[2]: *** [drivers/gpio/gpio-bt8xx.o] Error 1
> make[1]: *** [drivers/gpio] Error 2
> make: *** [drivers] Error 2
>
> drivers/media/video/bt8xx/bt848.h is moved to drivers/media/pci/bt8xx/bt848.h
> by commit 68de959f773a1d49096835c411390bceff5d1549
> "[media] bt8xx: move analog TV part to be together with DTV one".
>
> Signed-off-by: Axel Lin <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>

Thanks for the patch!

I'll apply this one on my tree, as it is due to the drivers/media tree
reorg. So, it is better to keep it close to the patches there.

Regards,
Mauro

> ---
> drivers/gpio/gpio-bt8xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-bt8xx.c b/drivers/gpio/gpio-bt8xx.c
> index e4cc7eb..92d555d 100644
> --- a/drivers/gpio/gpio-bt8xx.c
> +++ b/drivers/gpio/gpio-bt8xx.c
> @@ -50,7 +50,7 @@
> #include <linux/slab.h>
>
> /* Steal the hardware definitions from the bttv driver. */
> -#include "../media/video/bt8xx/bt848.h"
> +#include "../media/pci/bt8xx/bt848.h"
>
>
> #define BT8XXGPIO_NR_GPIOS 24 /* We have 24 GPIO pins */
>

2012-08-21 13:02:47

by Linus Walleij

Subject: Re: [PATCH] gpio: bt8xx: Fix build error due to missing include file

On Tue, Aug 21, 2012 at 1:23 PM, Mauro Carvalho Chehab
<[email protected]> wrote:
> Hi Axel,
>
> Em 21-08-2012 06:37, Axel Lin escreveu:
>> This patch fixes below build error:
>>
>> CC [M] drivers/gpio/gpio-bt8xx.o
>> drivers/gpio/gpio-bt8xx.c:53:40: fatal error: ../media/video/bt8xx/bt848.h: No such file or directory
>> compilation terminated.
>> make[2]: *** [drivers/gpio/gpio-bt8xx.o] Error 1
>> make[1]: *** [drivers/gpio] Error 2
>> make: *** [drivers] Error 2
>>
>> drivers/media/video/bt8xx/bt848.h is moved to drivers/media/pci/bt8xx/bt848.h
>> by commit 68de959f773a1d49096835c411390bceff5d1549
>> "[media] bt8xx: move analog TV part to be together with DTV one".
>>
>> Signed-off-by: Axel Lin <[email protected]>
>> Cc: Mauro Carvalho Chehab <[email protected]>
>
> Thanks for the patch!
>
> I'll apply this one on my tree, as it is due to the drivers/media tree
> reorg. So, it is better to keep it close to the patches there.

OK you take care of it!
Acked-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij