2012-08-21 14:39:44

by Arnaldo Carvalho de Melo

[permalink] [raw]
Subject: [GIT PULL 0/1] perf/urgent fix

Hi Ingo,

Please consider pulling,

- Arnaldo

The following changes since commit 5c65ca75209de8cc1802e7d3761b404957689cda:

Merge branch 'tip/perf/urgent' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace into perf/urgent (2012-08-21 11:49:37 +0200)

are available in the git repository at:


git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo

for you to fetch changes up to 3ab484b8622b7b890ca8d2ab5ee034c217ee4eeb:

perf tools: Add missing files to build the python binding (2012-08-21 10:31:40 -0300)

----------------------------------------------------------------
perf/urgent fix:

. Add missing object files needed to use the python binding, cherry-picked
from perf/core, got a report it affects Linus's too, fix it.

Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>

----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
perf tools: Add missing files to build the python binding

tools/perf/util/python-ext-sources | 2 ++
1 file changed, 2 insertions(+)


2012-08-21 14:39:41

by Arnaldo Carvalho de Melo

[permalink] [raw]
Subject: [PATCH 1/1] perf tools: Add missing files to build the python binding

From: Arnaldo Carvalho de Melo <[email protected]>

Changeset 0f6a3015:
"perf tools: Support user regs and stack in sample parsing"

uses hweight_long in evsel.c, so we need to drag util/hweight.c
to the python binding.

Ditto for ee8dd3c:
"perf tools: Change strlist to use the new rblist"

where we need to add util/rblist.c.

Now twatch.py works again:

# export PYTHONPATH=~acme/git/build/perf/python/
# ~acme/git/linux/tools/perf/python/twatch.py
cpu: 4, pid: 23639, tid: 23639 { type: fork, pid: 30659, ppid: 23639, tid: 30659, ptid: 23639, time: 36287872076780}
cpu: 5, pid: 30659, tid: 30659 { type: comm, pid: 30659, tid: 30659, comm: ls }
cpu: 5, pid: 30659, tid: 30659 { type: exit, pid: 30659, ppid: 30659, tid: 30659, ptid: 30659, time: 36287873681539}
cpu: 4, pid: 23639, tid: 23639 { type: fork, pid: 30660, ppid: 23639, tid: 30660, ptid: 23639, time: 36291720420480}
cpu: 5, pid: 30659, tid: 30659 { type: exit, pid: 30659, ppid: 30659, tid: 30659, ptid: 30659, time: 36287873685714}
cpu: 5, pid: 30660, tid: 30660 { type: comm, pid: 30660, tid: 30660, comm: git }
^C
KeyboardInterrupt

Reported-by: Jérôme Carretero <[email protected]>
Cc: David Ahern <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Mike Galbraith <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Stephane Eranian <[email protected]>
Link: http://lkml.kernel.org/n/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/util/python-ext-sources | 2 ++
1 file changed, 2 insertions(+)

diff --git a/tools/perf/util/python-ext-sources b/tools/perf/util/python-ext-sources
index 2884e67..2133628 100644
--- a/tools/perf/util/python-ext-sources
+++ b/tools/perf/util/python-ext-sources
@@ -10,10 +10,12 @@ util/ctype.c
util/evlist.c
util/evsel.c
util/cpumap.c
+util/hweight.c
util/thread_map.c
util/util.c
util/xyarray.c
util/cgroup.c
util/debugfs.c
+util/rblist.c
util/strlist.c
../../lib/rbtree.c
--
1.7.9.2.358.g22243

2012-08-21 14:58:59

by Ingo Molnar

[permalink] [raw]
Subject: Re: [GIT PULL 0/1] perf/urgent fix


* Arnaldo Carvalho de Melo <[email protected]> wrote:

> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 5c65ca75209de8cc1802e7d3761b404957689cda:
>
> Merge branch 'tip/perf/urgent' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace into perf/urgent (2012-08-21 11:49:37 +0200)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo
>
> for you to fetch changes up to 3ab484b8622b7b890ca8d2ab5ee034c217ee4eeb:
>
> perf tools: Add missing files to build the python binding (2012-08-21 10:31:40 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fix:
>
> . Add missing object files needed to use the python binding, cherry-picked
> from perf/core, got a report it affects Linus's too, fix it.
>
> Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
> perf tools: Add missing files to build the python binding
>
> tools/perf/util/python-ext-sources | 2 ++
> 1 file changed, 2 insertions(+)

Pulled, thanks!

Ingo