2012-08-23 08:53:28

by Devendra Naga

Subject: [PATCH] misc: use module_spi_driver

The _init and _exit functions can be replaced with the module_spi_driver
macro, which actually implements

static int __init drv_init(void)
{
spi_register_driver(&driv_op);
return 0;
}

module_init(drv_init);

static void __exit drv_exit(void)
{
spi_unregister_driver(&driv_op);
}

module_exit(drv_exit);

Signed-off-by: Devendra Naga <[email protected]>
---
drivers/misc/bmp085-spi.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/drivers/misc/bmp085-spi.c b/drivers/misc/bmp085-spi.c
index 78aaff9..5e982af 100644
--- a/drivers/misc/bmp085-spi.c
+++ b/drivers/misc/bmp085-spi.c
@@ -73,19 +73,8 @@ static struct spi_driver bmp085_spi_driver = {
.remove = __devexit_p(bmp085_spi_remove)
};

-static int __init bmp085_spi_init(void)
-{
- return spi_register_driver(&bmp085_spi_driver);
-}
-
-static void __exit bmp085_spi_exit(void)
-{
- spi_unregister_driver(&bmp085_spi_driver);
-}
+module_spi_driver(bmp085_spi_driver);

MODULE_AUTHOR("Eric Andersson <[email protected]>");
MODULE_DESCRIPTION("BMP085 SPI bus driver");
MODULE_LICENSE("GPL");
-
-module_init(bmp085_spi_init);
-module_exit(bmp085_spi_exit);
--
1.7.9.5

2012-08-23 10:35:58

by Arnd Bergmann

Subject: Re: [PATCH] misc: use module_spi_driver

On Thursday 23 August 2012, Devendra Naga wrote:
> The _init and _exit functions can be replaced with the module_spi_driver
> macro, which actually implements
>
> static int __init drv_init(void)
> {
> spi_register_driver(&driv_op);
> return 0;
> }
>
> module_init(drv_init);
>
> static void __exit drv_exit(void)
> {
> spi_unregister_driver(&driv_op);
> }
>
> module_exit(drv_exit);
>
> Signed-off-by: Devendra Naga <[email protected]>

Acked-by: Arnd Bergmann <[email protected]>