2012-08-28 11:30:58

by Axel Lin

Subject: [PATCH] gpio: em: Fix checking return value of irq_alloc_descs

irq_alloc_descs() returns negative error code on failure.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/gpio/gpio-em.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-em.c b/drivers/gpio/gpio-em.c
index ae37181..ec48ed5 100644
--- a/drivers/gpio/gpio-em.c
+++ b/drivers/gpio/gpio-em.c
@@ -247,9 +247,9 @@ static int __devinit em_gio_irq_domain_init(struct em_gio_priv *p)

p->irq_base = irq_alloc_descs(pdata->irq_base, 0,
pdata->number_of_pins, numa_node_id());
- if (IS_ERR_VALUE(p->irq_base)) {
+ if (p->irq_base < 0) {
dev_err(&pdev->dev, "cannot get irq_desc\n");
- return -ENXIO;
+ return p->irq_base;
}
pr_debug("gio: hw base = %d, nr = %d, sw base = %d\n",
pdata->gpio_base, pdata->number_of_pins, p->irq_base);
--
1.7.9.5

2012-08-31 00:05:05

by Linus Walleij

Subject: Re: [PATCH] gpio: em: Fix checking return value of irq_alloc_descs

On Tue, Aug 28, 2012 at 4:30 AM, Axel Lin <[email protected]> wrote:

> irq_alloc_descs() returns negative error code on failure.
>
> Signed-off-by: Axel Lin <[email protected]>

Magnuis can I have your ACK on this?

Yours,
Linus Walleij

2012-08-31 01:23:37

by Magnus Damm

Subject: Re: [PATCH] gpio: em: Fix checking return value of irq_alloc_descs

On Fri, Aug 31, 2012 at 9:05 AM, Linus Walleij <[email protected]> wrote:
> On Tue, Aug 28, 2012 at 4:30 AM, Axel Lin <[email protected]> wrote:
>
>> irq_alloc_descs() returns negative error code on failure.
>>
>> Signed-off-by: Axel Lin <[email protected]>
>
> Magnuis can I have your ACK on this?

Yes, of course! I never disagree with bug fixes =)

Acked-by: Magnus Damm <[email protected]>

Thanks a lot to both Axel and you!

/ magnus

2012-08-31 23:19:17

by Linus Walleij

Subject: Re: [PATCH] gpio: em: Fix checking return value of irq_alloc_descs

On Tue, Aug 28, 2012 at 1:30 PM, Axel Lin <[email protected]> wrote:

> irq_alloc_descs() returns negative error code on failure.
>
> Signed-off-by: Axel Lin <[email protected]>

Applied with Magnus' ACK.

Yours,
Linus Walleij