Cc: Luciano Coelho <[email protected]>
Cc: "John W. Linville" <[email protected]>
Cc: Eliad Peller <[email protected]>
Cc: Arik Nemtsov <[email protected]>
Cc: Eyal Shapira <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Tim Gardner <[email protected]>
---
drivers/net/wireless/ti/wlcore/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
index 7254860..a55ace6 100644
--- a/drivers/net/wireless/ti/wlcore/main.c
+++ b/drivers/net/wireless/ti/wlcore/main.c
@@ -5663,3 +5663,4 @@ MODULE_PARM_DESC(no_recovery, "Prevent HW recovery. FW will remain stuck.");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Luciano Coelho <[email protected]>");
MODULE_AUTHOR("Juuso Oikarinen <[email protected]>");
+MODULE_FIRMWARE(WL12XX_NVS_NAME);
--
1.7.9.5
On Wed, 2012-08-29 at 08:48 -0600, Tim Gardner wrote:
> Cc: Luciano Coelho <[email protected]>
> Cc: "John W. Linville" <[email protected]>
> Cc: Eliad Peller <[email protected]>
> Cc: Arik Nemtsov <[email protected]>
> Cc: Eyal Shapira <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Tim Gardner <[email protected]>
> ---
Please add a proper commit message. And there's no need to put all
these people in Cc: in the commit log. CC'ing when sending the patch is
enough (even though for such small patch, the linux-wireless mailing
list and myself is enough).
--
Luca.
On 08/29/2012 11:01 AM, Luciano Coelho wrote:
> On Wed, 2012-08-29 at 08:48 -0600, Tim Gardner wrote:
>> Cc: Luciano Coelho <[email protected]>
>> Cc: "John W. Linville" <[email protected]>
>> Cc: Eliad Peller <[email protected]>
>> Cc: Arik Nemtsov <[email protected]>
>> Cc: Eyal Shapira <[email protected]>
>> Cc: [email protected]
>> Cc: [email protected]
>> Signed-off-by: Tim Gardner <[email protected]>
>> ---
>
> Please add a proper commit message. And there's no need to put all
> these people in Cc: in the commit log. CC'ing when sending the patch is
> enough (even though for such small patch, the linux-wireless mailing
> list and myself is enough).
>
> --
> Luca.
>
What more would you like covered in the commit message that isn't
obvious from the subject?
The Cc list comes from scripts/get_maintainers.pl as suggested by
Documentation/SubmittingPatches: "5) Select e-mail destination."
rtg
--
Tim Gardner [email protected]
On Wed, 2012-08-29 at 11:13 -0600, Tim Gardner wrote:
> On 08/29/2012 11:01 AM, Luciano Coelho wrote:
> > On Wed, 2012-08-29 at 08:48 -0600, Tim Gardner wrote:
> >> Cc: Luciano Coelho <[email protected]>
> >> Cc: "John W. Linville" <[email protected]>
> >> Cc: Eliad Peller <[email protected]>
> >> Cc: Arik Nemtsov <[email protected]>
> >> Cc: Eyal Shapira <[email protected]>
> >> Cc: [email protected]
> >> Cc: [email protected]
> >> Signed-off-by: Tim Gardner <[email protected]>
> >> ---
> >
> > Please add a proper commit message. And there's no need to put all
> > these people in Cc: in the commit log. CC'ing when sending the patch is
> > enough (even though for such small patch, the linux-wireless mailing
> > list and myself is enough).
> >
> > --
> > Luca.
> >
>
> What more would you like covered in the commit message that isn't
> obvious from the subject?
It's obvious from the subject, indeed. But commits with no descriptions
are ugly. Add something, for example a small "why" would be nice.
> The Cc list comes from scripts/get_maintainers.pl as suggested by
> Documentation/SubmittingPatches: "5) Select e-mail destination."
Yeah, that's correct, but it doesn't mean you should put them as Cc:
tags in the commit log. CCing when *sending* the email only is enough.
Most people won't really care for the entire lifetime of this patch.
And, come on, the Cc tags take more space than the actual patch.
--
Luca.
Declare any firmware that might be used by this driver.
If all drivers declare their firmware usage, then a sufficiently
complete list of firmware files can then be used to pare down
the external linux-firmware package to just the files in actual use.
Cc: Luciano Coelho <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Tim Gardner <[email protected]>
---
drivers/net/wireless/ti/wlcore/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
index 7254860..a55ace6 100644
--- a/drivers/net/wireless/ti/wlcore/main.c
+++ b/drivers/net/wireless/ti/wlcore/main.c
@@ -5663,3 +5663,4 @@ MODULE_PARM_DESC(no_recovery, "Prevent HW recovery. FW will remain stuck.");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Luciano Coelho <[email protected]>");
MODULE_AUTHOR("Juuso Oikarinen <[email protected]>");
+MODULE_FIRMWARE(WL12XX_NVS_NAME);
--
1.7.9.5