2012-10-01 09:04:39

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCHv3] dw_dmac: autoconfigure data_width or get it via platform data

On Thu, 2012-09-27 at 16:03 +0530, Vinod Koul wrote:
> On Thu, 2012-09-27 at 15:36 +0530, Vinod Koul wrote:
> > On Tue, 2012-09-25 at 14:39 +0300, Andy Shevchenko wrote:
> > > Not all of the controllers support the 64 bit data width. Make it configurable
> > > via platform data. The driver will try to get a value from the component
> > > parameters, otherwise it will use the platform data.
> > >
> > What was this gen against, I can apply this.
> %s/can/can't
Today I got what was happened. I sent an update to one patch of the
series, but you tried to apply it on top of previous version. It seems I
was not clear. So, now we have a regression, and I will send a fix soon
today.


--
Andy Shevchenko <[email protected]>
Intel Finland Oy


2012-10-01 09:52:48

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCHv3] dw_dmac: autoconfigure data_width or get it via platform data

On Mon, 2012-10-01 at 12:04 +0300, Andy Shevchenko wrote:
> On Thu, 2012-09-27 at 16:03 +0530, Vinod Koul wrote:
> > On Thu, 2012-09-27 at 15:36 +0530, Vinod Koul wrote:
> > > On Tue, 2012-09-25 at 14:39 +0300, Andy Shevchenko wrote:
> > > > Not all of the controllers support the 64 bit data width. Make it configurable
> > > > via platform data. The driver will try to get a value from the component
> > > > parameters, otherwise it will use the platform data.
> > > >
> > > What was this gen against, I can apply this.
> > %s/can/can't
> Today I got what was happened. I sent an update to one patch of the
> series, but you tried to apply it on top of previous version. It seems I
> was not clear. So, now we have a regression, and I will send a fix soon
> today.
I received a series, and a patch on top and that what I tried to
apply :(
I am okay to revert the whole series now.

Please send me fix by today, merge window has started, I hate to change
stuff now.



--
~Vinod

2012-10-01 10:07:41

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCHv3] dw_dmac: autoconfigure data_width or get it via platform data

On Mon, 2012-10-01 at 15:15 +0530, Vinod Koul wrote:
> On Mon, 2012-10-01 at 12:04 +0300, Andy Shevchenko wrote:
> > On Thu, 2012-09-27 at 16:03 +0530, Vinod Koul wrote:
> > > On Thu, 2012-09-27 at 15:36 +0530, Vinod Koul wrote:
> > > > On Tue, 2012-09-25 at 14:39 +0300, Andy Shevchenko wrote:
> > > > > Not all of the controllers support the 64 bit data width. Make it configurable
> > > > > via platform data. The driver will try to get a value from the component
> > > > > parameters, otherwise it will use the platform data.
> > > > >
> > > > What was this gen against, I can apply this.
> > > %s/can/can't
> > Today I got what was happened. I sent an update to one patch of the
> > series, but you tried to apply it on top of previous version. It seems I
> > was not clear. So, now we have a regression, and I will send a fix soon
> > today.
> I received a series, and a patch on top and that what I tried to
> apply :(
> I am okay to revert the whole series now.
>
> Please send me fix by today, merge window has started, I hate to change
> stuff now.
I've sent a patch. You could apply on top of the series, or squash it
with the one called "dw_dmac: autoconfigure data_width or get it via
platform data"

--
Andy Shevchenko <[email protected]>
Intel Finland Oy