2012-10-04 12:36:36

by Ezequiel Garcia

[permalink] [raw]
Subject: [PATCH] lib: Use kmalloc_track_caller to get accurate traces for kvasprintf

Previously kvasprintf allocation was being done through kmalloc,
thus producing an unaccurate trace report.

This is a common problem: in order to get accurate callsite tracing,
a lib/utils function shouldn't allocate kmalloc but instead
use kmalloc_track_caller.

Cc: Sam Ravnborg <[email protected]>
Cc: Andrew Morton <[email protected]>
Signed-off-by: Ezequiel Garcia <[email protected]>
---
lib/kasprintf.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/kasprintf.c b/lib/kasprintf.c
index ae0de80..32f1215 100644
--- a/lib/kasprintf.c
+++ b/lib/kasprintf.c
@@ -21,7 +21,7 @@ char *kvasprintf(gfp_t gfp, const char *fmt, va_list ap)
len = vsnprintf(NULL, 0, fmt, aq);
va_end(aq);

- p = kmalloc(len+1, gfp);
+ p = kmalloc_track_caller(len+1, gfp);
if (!p)
return NULL;

--
1.7.8.6