2012-10-14 11:21:52

by Sangho Yi

Subject: [PATCH] Drivers: Staging: CSR: made corrections on the indentation errors

Originally there were a lot mis-indentation, so I made changes to use
only the tabs (no spaces) on indenting code.
- Still, the typedef struct ... tells warning message on checkpatch.pl.

Signed-off-by: Sangho Yi <[email protected]>
---
drivers/staging/csr/csr_time.h | 54 ++++++++++++++++++++--------------------
1 file changed, 27 insertions(+), 27 deletions(-)

diff --git a/drivers/staging/csr/csr_time.h b/drivers/staging/csr/csr_time.h
index 2a45f3e..e3cae82 100644
--- a/drivers/staging/csr/csr_time.h
+++ b/drivers/staging/csr/csr_time.h
@@ -2,11 +2,11 @@
#define CSR_TIME_H__
/*****************************************************************************

- (c) Cambridge Silicon Radio Limited 2010
- All rights reserved and confidential information of CSR
+ (c) Cambridge Silicon Radio Limited 2010
+ All rights reserved and confidential information of CSR

- Refer to LICENSE.txt included with this source for details
- on the license terms.
+ Refer to LICENSE.txt included with this source for details
+ on the license terms.

*****************************************************************************/

@@ -19,12 +19,12 @@ extern "C" {
/*******************************************************************************

NAME
- CsrTime
+ CsrTime

DESCRIPTION
- Type to hold a value describing the current system time, which is a
- measure of time elapsed since some arbitrarily defined fixed time
- reference, usually associated with system startup.
+ Type to hold a value describing the current system time, which is a
+ measure of time elapsed since some arbitrarily defined fixed time
+ reference, usually associated with system startup.

*******************************************************************************/
typedef u32 CsrTime;
@@ -33,43 +33,43 @@ typedef u32 CsrTime;
/*******************************************************************************

NAME
- CsrTimeUtc
+ CsrTimeUtc

DESCRIPTION
- Type to hold a value describing a UTC wallclock time expressed in
- seconds and milliseconds elapsed since midnight January 1st 1970.
+ Type to hold a value describing a UTC wallclock time expressed in
+ seconds and milliseconds elapsed since midnight January 1st 1970.

*******************************************************************************/
-typedef struct
-{
- u32 sec;
- u16 msec;
+typedef struct _CsrTimeUtc {
+ u32 sec;
+ u16 msec;
} CsrTimeUtc;


/*******************************************************************************

NAME
- CsrTimeGet
+ CsrTimeGet

DESCRIPTION
- Returns the current system time in a low and a high part. The low part
- is expressed in microseconds. The high part is incremented when the low
- part wraps to provide an extended range.
+ Returns the current system time in a low and a high part. The low part
+ is expressed in microseconds. The high part is incremented when the low
+ part wraps to provide an extended range.

- The caller may provide a NULL pointer as the high parameter. In this case
- the function just returns the low part and ignores the high parameter.
+ The caller may provide a NULL pointer as the high parameter.
+ In this case the function just returns the low part and ignores the
+ high parameter.

- Although the time is expressed in microseconds the actual resolution is
- platform dependent and can be less. It is recommended that the
- resolution is at least 10 milliseconds.
+ Although the time is expressed in microseconds the actual resolution is
+ platform dependent and can be less. It is recommended that the
+ resolution is at least 10 milliseconds.

PARAMETERS
- high - Pointer to variable that will receive the high part of the
- current system time. Passing NULL is valid.
+ high - Pointer to variable that will receive the high part of the
+ current system time. Passing NULL is valid.

RETURNS
- Low part of current system time in microseconds.
+ Low part of current system time in microseconds.

*******************************************************************************/
CsrTime CsrTimeGet(CsrTime *high);
--
1.7.9.5

2012-10-14 11:27:00

by Greg Kroah-Hartman

Subject: Re: [PATCH] Drivers: Staging: CSR: made corrections on the indentation errors

On Sun, Oct 14, 2012 at 08:20:11PM +0900, Sangho Yi wrote:
> Originally there were a lot mis-indentation, so I made changes to use
> only the tabs (no spaces) on indenting code.
> - Still, the typedef struct ... tells warning message on checkpatch.pl.

Yes, we shouldn't be using a typedef, but why did you change the typedef
itself:

> -typedef struct
> -{
> - u32 sec;
> - u16 msec;
> +typedef struct _CsrTimeUtc {
> + u32 sec;
> + u16 msec;
> } CsrTimeUtc;

Why add the _CsrTimeUtc here? That's not really needed, right?

thanks,

greg k-h